Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert icon helper to Typescript #2360

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Convert icon helper to Typescript #2360

merged 3 commits into from
Oct 5, 2020

Commits on Oct 5, 2020

  1. Convert icon helper to Typescript

    @lhsazevedo
    lhsazevedo committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    ff1b208 View commit details
    Browse the repository at this point in the history

  2. Use namespaced Mithril import for consistency 

    Use "import * as Mithril" instead of "import { ... } from"
    @lhsazevedo
    lhsazevedo authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    f81fbdb View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary JSDoc types from icon helper 

    They can be inferred from Typescript types
    @lhsazevedo
    lhsazevedo authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    c53d42c View commit details
    Browse the repository at this point in the history