Convert icon helper to Typescript #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsevillamartin
approved these changes
Oct 5, 2020
tankerkiller125
approved these changes
Oct 5, 2020
|
Thank you! Let me know if I should update the imports, no problem. |
askvortsov1
reviewed
Oct 5, 2020
js/src/common/helpers/icon.tsx
Outdated
| */ | ||
| export default function icon(fontClass, attrs = {}) { | ||
| export default function icon(fontClass: string, attrs: Attributes = {}): Vnode { |
There was a problem hiding this comment.
Do we want to use ComponentAttrs instead of Mithril's Attributes, or do we only want to do that for our custom components?
There was a problem hiding this comment.
This is not necessarily a component, and it doesn't really matter as ComponentAttrs are mainly used for the this.attrs type hinting in component classes. It doesn't apply here.
askvortsov1
requested changes
Oct 5, 2020
js/src/common/helpers/icon.tsx
Outdated
| @@ -1,11 +1,13 @@ | |||
| import { Attributes, Vnode } from 'mithril'; | |||
There was a problem hiding this comment.
Tbh, I would prefer sticking to Mithril.Vnode and Mithril.Attributes just for sake of consistency.
Use "import * as Mithril" instead of "import { ... } from"
lhsazevedo
commented
Oct 5, 2020
They can be inferred from Typescript types
askvortsov1
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert common icon helper to Typescript. See #3533
Confirmed