Update Guardian Admin UI to match Figma spec #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gn to match figma
This was referenced Aug 31, 2023
EthnTuttle
reviewed
Sep 1, 2023
There was a problem hiding this comment.
Not finished but left some comments.
Still need to review:
- apps/guardian-ui/src/admin/FederationAdmin.tsx
- apps/guardian-ui/src/components/BalanceCard.tsx
- apps/guardian-ui/src/components/BitcoinNodeCard.tsx
- apps/guardian-ui/src/components/FederationInfoCard.tsx
- apps/guardian-ui/src/components/GatewaysCard.tsx
EthnTuttle
requested changes
Sep 2, 2023
| const { t } = useTranslation(); | ||
| const { api } = useAdminContext(); | ||
| const [versions, setVersions] = useState<Versions>(); | ||
| const [epochCount, setEpochCount] = useState<number>(); |
There was a problem hiding this comment.
Building on other discussions around a similar topic, wonder when we need to migrate this to bigint.
| const [gateways, setGateways] = useState<Gateway[]>([]); | ||
|
|
||
| const lnModuleId = config | ||
| ? Object.entries(config.client_config.modules).find( |
There was a problem hiding this comment.
I wonder about some utils around modules.
| borderTopLeftRadius={0} | ||
| borderBottomLeftRadius={0} | ||
| size={size} | ||
| height={size == 'lg' ? '46px' : '42px'} | ||
| height='100%' |
There was a problem hiding this comment.
Shouldn't this be buttonHeight?
Suggested change
| height='100%' | |
| height={buttonHeight} |
|
Going to approve and merge to unlock all the other PRs. |
EthnTuttle
approved these changes
Sep 2, 2023
This was referenced Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166, closes #64, closes #95 (sorta?), closes #27, closes #148
Apologies for the size of this PR. Doing it all at once made it easier to get the organization and component abstractions right the first time, rather than having to re-work it a piece at a time.
What This Does
Cardcomponent now matches Figma specTablecomponent now matches Figma specCopyInputcomponent now matches Figma specsmsize support<Input readOnly />now renders with lighter textWrappercomponent now matches Figma specsize="md|lg"prop for admin's wider 1200px templateStatusIndicatorcomponentPillinguardian-ui, but no longer comes with the label prefixKeyValuescomponent for displaying lists of information with a label on top and a value below<Wrapper size="lg">to match Figma spec widthCardstylesNote that some deviations to the Figma spec were made to match the information we have available:
Screenshots
Guardian UI admin
Gateway UI