Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Peer ID to Federation Admin dashboard #181

Closed
EthnTuttle opened this issue Sep 2, 2023 · 2 comments · Fixed by #462
Closed

Add Peer ID to Federation Admin dashboard #181

EthnTuttle opened this issue Sep 2, 2023 · 2 comments · Fixed by #462
Labels
good first issue Good for newcomers guardian-ui

Comments

@EthnTuttle
Copy link
Collaborator

See #168 (comment)
@EthnTuttle EthnTuttle mentioned this issue Sep 2, 2023
Merged
@justinmoon
Copy link
Contributor

What is the reasoning here? I always think of "peer id" as an implementation detail that we probably shouldn't show to users.

@EthnTuttle
Copy link
Collaborator Author

What is the reasoning here? I always think of "peer id" as an implementation detail that we probably shouldn't show to users.

Since Guardians are responsible for managing their nodes/servers, I think surfacing the PeerId is useful since fedimintd logs show PeerId as a reference in multiple location but does not map that to a Guardian name. Additionally, if there is a federation of four Ethans, then PeerId can help differentiate between them (extreme user inflicted edge case but I think valid)

@harsh-ps-2003 harsh-ps-2003 mentioned this issue Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers guardian-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Peer ID to Federation Admin dashboard harsh-ps-2003/ui
2 participants
@justinmoon @EthnTuttle