Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coo #869

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

coo #869

wants to merge 2 commits into from

Conversation

joostvanzwieten
Copy link
Member

No description provided.

@joostvanzwieten
disable testing sparse evaluation of bool arrays
3566344
@joostvanzwieten
assemble into sorted and deduped coo directly
2ae40b8 
Currently we assemble sparse matrices as unstructured coo with repeated indices
and sort and dedup later. The downside of this approach is that we're wasting
memory because of the duplicated indices, and if we're assembling a matrix more
than once, e.g. for Newton, we always have to sort and dedup, even if the
sparse structure doesn't change.

This patch changes `Evaluable.assparse` such that the indices are sorted and
deduped first, and the values are then inflated using the unique indices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joostvanzwieten