Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coo #869

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

coo #869

wants to merge 2 commits into from

Commits on Oct 24, 2024

  1. disable testing sparse evaluation of bool arrays

    @joostvanzwieten
    joostvanzwieten committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    3566344 View commit details
    Browse the repository at this point in the history

  2. assemble into sorted and deduped coo directly 

    Currently we assemble sparse matrices as unstructured coo with repeated indices
and sort and dedup later. The downside of this approach is that we're wasting
memory because of the duplicated indices, and if we're assembling a matrix more
than once, e.g. for Newton, we always have to sort and dedup, even if the
sparse structure doesn't change.

This patch changes `Evaluable.assparse` such that the indices are sorted and
deduped first, and the values are then inflated using the unique indices.
    @joostvanzwieten
    joostvanzwieten committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2ae40b8 View commit details
    Browse the repository at this point in the history