-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Privacy Pro translations #3656
Conversation
…port proper localisation
|
static let networkProtectionStatusMenuSendFeedback = NSLocalizedString("dbp.menu.send.feedback", value: "Send Feedback…", comment: "The status menu 'Send Feedback' menu item") | ||
static let networkProtectionStatusMenuOpenDuckDuckGo = NSLocalizedString("dbp.open.duckduckgo", value: "Open DuckDuckGo…", comment: "The status menu 'Open DuckDuckGo' menu item") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is strange here - it's a Network Protection string, but in a DBP file, with a DBP prefix. At the end of the day it should work as intended, but caught me off guard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was a copy paste issue and fixed the string ID but completely missed the variable name. I see it is not used anywhere, maybe it was a placeholder to setup localizations. Since they are not used anywhere I will proceed and delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good in most areas, I noticed that the VPN settings UI is largely untranslated and that some strings in the submenus are missing though. I recall some of these were still going through translation, so apologies if I'm pointing out the obvious - just capturing all issues I see to be safe.
Thanks for the review @samsymons. Regarding the VPN translations I have last translation job to import today, and I will double check the PIR message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to add English (United States) as language to the Localizable files of the new packages (as done in SyncUI).
This is to get around an apple issue.
Applied all suggested changes. The DBP strings happened to be |
Task/Issue URL: https://app.asana.com/0/0/1208750072186506/f
CC: @SabrinaTardio
Description:
Update Privacy Pro and VPN related translations.
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Change preferred language for the app and verify completeness for:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation