Update drupal core to v10.3.1

[edmund-dunn]

User Story or Problem Statement

Drupal core is now on v10.3.1. We need to update it.

Description or Additional Context

Additional packages in AC are dependent on core v10.3

Order of Operations

• Sprint 16: Update Drupal core for sitewide teams to review.
• Sprint 17: Have sitewide Drupal developers spot check their products. No major review is needed, just a spot check that should only take sitewide developers an hour.
• End of Sprint 17: Push Drupal core upgrade into production.

Reference Links

• Update core to 10.2.5 #18072
• Update core to 10.2.2 #16898
• VACMS-16898: upgrade drupal core to 10.2.2 #16899
• Upgrade Core to 9.5.11, critical security vulnerability SA-CORE-2023-006 #15332

Acceptance Criteria

• drupal/core-recommended package update to 10.3.1 with all dependencies
• drupal/core-composer-scaffold package updated to 10.3.1 with all dependencies
• drupal/twig_tweak package update to v3.4
• drupal/animated_gifpackage updated to v2.1
• Sitewide developers review their products impacted by Drupal core upgrade.

[edmund-dunn]

@gracekretschmer-metrostar this should be a higher priority

[gracekretschmer-metrostar]

Next steps: Grace will preview this to sitewide teams this week. In the past, we have owned the PR and the sitewide teams have been reviewers.

[JakeBapple]

Two files in the most recent patch (found here) that are being rejected:
/core/modules/system/tests/modules/cron_queue_test/src/Plugin/QueueWorker/CronQueueTestDatabaseDelayException.php
/core/modules/system/tests/modules/cron_queue_test/src/Plugin/QueueWorker/CronQueueTestLeaseTime.php

Need to fix those files in the patch and re-submit the patch back to the issue with the 10.3.x fix.

[JakeBapple]

Another patch needs to be re-rolled for this update (here):

/core/modules/text/src/Plugin/Field/FieldWidget/TextareaWithSummaryWidget.php

[JakeBapple]

Patch rerolled for the first two files here and uploaded for drupal community support.

[JakeBapple]

Patch rerolled for TextAreaWidget uploaded here for drupal community.

[JakeBapple]

Patch re-rolled for role status and uploaded for drupal community here.

[JakeBapple]

Removed this patch (referenced here) as it has been reported "fixed" in core: "3047110 - Add workflow to taxonomy": "https://www.drupal.org/files/issues/2023-04-14/3047110-45.patch"

[JakeBapple]

Local patch not applying correctly: 3333401 - Pager h4 cause accessibility flag on many pages (patches/3333401-configurable-pager-heading-default-h2.patch). Many issues, all fixed in PR.

NOTE:
This patch was addressing headers being inserted, and since 10.3.2, Drupal core has put in some variable logic in all relevant templates. This may warrant looking at refactoring at the template level or just getting what's in core. @edmund-dunn

[JakeBapple]

Had to update https://www.drupal.org/project/eca to ^2.0 and https://www.drupal.org/project/eca_cm to ^1.0 and "drupal/monolog": "^3.0".
updatedb to eca (8009) throwing errors, fix pushed by @dsasser

[JakeBapple]

The PR is clearing tests and is ready for confirmation from other product teams that it is working for their interests. Waiting to merge based on feedback.

[omahane]

We found a visual regression in the taxonomy form: #19020

[gracekretschmer-metrostar]

@JakeBapple ^^^

[gracekretschmer-metrostar]

@omahane Christian we determined that #19020 is not a visual regression, but a new feature, so we are not going to pick it up.

cc: @edmund-dunn @JakeBapple @jilladams

[omahane]

@omahane Christian we determined that #19020 is not a visual regression, but a new feature, so we are not going to pick it up.

OK, I don't really understand the feature, but it was not a show-stopper either way.