-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-18703: Updating core to 10.3.2. #18956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and monolog module updates.
JakeBapple
added
CMS Team
CMS Product team that manages both editor exp and devops
Drupal upgrade
labels
Aug 15, 2024
5 tasks
GitHub Workflows (.github/workflows/*.yml)Have you...
|
3 tasks
…1' into 18703-update-drupal-core-to-v1031
…ment-of-veterans-affairs/va.gov-cms into 18703-update-drupal-core-to-v1031
@gracekretschmer-metrostar @JakeBapple @edmund-dunn I finished my review of our products and didn't see regressions: #18844 (comment) |
edmund-dunn
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!!
keisterj-oddball
pushed a commit
that referenced
this pull request
Sep 19, 2024
* 18703-update-drupal-core-to-v1031: Updating core and rerolling patches for v1032. * 18703-update-drupal-core-to-v1031: Updating ECA contrib module to apply to 1032. * 18703-update-drupal-core-to-v1031: Pushing twig_tweak, animated_gif, and monolog module updates. * VACMS-18703: Resolves ECA action error after upgrading to ECA 2.x. * 18703-update-drupal-core-to-v1031: Fixing hash conflict. * VACMS-18703: fix for datadogprocessor error * 180703-update-drupal-core-to-v1031: Resolving lock file conflicts. * VACMS-18703: fix for phpunit tests * VACMS-18703: fix for change to /user/logout route for cypress test * VACMS-18703: Fix for ViewsResultCondition ECA Condition plugin. * 18703-update-core-to-v1031: Fixing lockfile conflict. * 18703-update-drupal-core-to-v1031: Fixing composer conflict. --------- Co-authored-by: Daniel Sasser <[email protected]> Co-authored-by: Edmund Dunn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #18703.
Testing done
Local file generation.
Screenshots
QA steps
What needs to be checked to prove this works?
Pull branch locally, run ddev drush cr then ddev drush composer install.
What needs to be checked to prove it didn't break any related things?
All site should function as normal.
What variations of circumstances (users, actions, values) need to be checked?
ECA module was a problem so anything that touches that.
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?