Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18703: Updating core to 10.3.2. #18956

Merged
merged 23 commits into from
Sep 3, 2024

Conversation

JakeBapple
Copy link
Contributor

Description

Closes #18703.

Testing done

Local file generation.

Screenshots

QA steps

What needs to be checked to prove this works?
Pull branch locally, run ddev drush cr then ddev drush composer install.
What needs to be checked to prove it didn't break any related things?
All site should function as normal.
What variations of circumstances (users, actions, values) need to be checked?
ECA module was a problem so anything that touches that.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@JakeBapple JakeBapple added CMS Team CMS Product team that manages both editor exp and devops Drupal upgrade labels Aug 15, 2024
@JakeBapple JakeBapple requested a review from edmund-dunn August 15, 2024 15:29
@JakeBapple JakeBapple self-assigned this Aug 15, 2024
@JakeBapple JakeBapple requested review from a team as code owners August 15, 2024 15:29
@JakeBapple JakeBapple linked an issue Aug 15, 2024 that may be closed by this pull request
5 tasks
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 15, 2024 15:29 Destroyed
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 15, 2024 16:08 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 15, 2024 16:17 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 15, 2024 16:59 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 15, 2024 20:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 19, 2024 14:52 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 19, 2024 18:10 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 20, 2024 14:18 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 27, 2024 23:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 27, 2024 23:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 28, 2024 19:05 Destroyed
@omahane
Copy link
Contributor

omahane commented Aug 29, 2024

@gracekretschmer-metrostar @JakeBapple @edmund-dunn I finished my review of our products and didn't see regressions: #18844 (comment)

Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 3, 2024 14:16 Destroyed
@edmund-dunn edmund-dunn merged commit 66496c6 into main Sep 3, 2024
18 checks passed
@edmund-dunn edmund-dunn deleted the 18703-update-drupal-core-to-v1031 branch September 3, 2024 15:32
keisterj-oddball pushed a commit that referenced this pull request Sep 19, 2024
* 18703-update-drupal-core-to-v1031: Updating core and rerolling patches for v1032.

* 18703-update-drupal-core-to-v1031: Updating ECA contrib module to apply to 1032.

* 18703-update-drupal-core-to-v1031: Pushing twig_tweak, animated_gif, and monolog module updates.

* VACMS-18703: Resolves ECA action error after upgrading to ECA 2.x.

* 18703-update-drupal-core-to-v1031: Fixing hash conflict.

* VACMS-18703: fix for datadogprocessor error

* 180703-update-drupal-core-to-v1031: Resolving lock file conflicts.

* VACMS-18703: fix for phpunit tests

* VACMS-18703: fix for change to /user/logout route for cypress test

* VACMS-18703: Fix for ViewsResultCondition ECA Condition plugin.

* 18703-update-core-to-v1031: Fixing lockfile conflict.

* 18703-update-drupal-core-to-v1031: Fixing composer conflict.

---------

Co-authored-by: Daniel Sasser <[email protected]>
Co-authored-by: Edmund Dunn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update drupal core to v10.3.1
5 participants