Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change metadata to meta #6570

Closed
anakin87 opened this issue Dec 15, 2023 · 3 comments · Fixed by #6605
Closed

Change metadata to meta #6570

anakin87 opened this issue Dec 15, 2023 · 3 comments · Fixed by #6605
Assignees
@vblagoje @anakin87
Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint
Milestone
2.0.0

Comments

@anakin87
Copy link
Member

Here and there, some Components and Dataclasses use metadata,
while we decided for meta.

Some examples:

  • Embedders (in haystack and haystack-core-integrations)
  • ByteStream dataclass
@anakin87 anakin87 mentioned this issue Dec 15, 2023
Merged
@masci masci added this to the 2.0.0 milestone Dec 15, 2023
@masci masci added the 2.x Related to Haystack v2.0 label Dec 15, 2023
@sahusiddharth
Copy link
Contributor

sahusiddharth commented Dec 17, 2023 •
edited
Loading

Screenshot 2023-12-17 at 7 47 50 PM The function is returning a dictionary with metadata as key, do they need to be changed as well?

I don't think they should be changed. Just clarifying ; )

@sahusiddharth sahusiddharth mentioned this issue Dec 18, 2023
Closed
@sahusiddharth sahusiddharth mentioned this issue Dec 20, 2023
Merged
@anakin87 anakin87 mentioned this issue Dec 21, 2023
Merged
@anakin87
Copy link
Member Author

Unfortunately, there are still some mentions of metadata: e.g., metadata_fields_to_embed in some Embedders.

I'm reopening this issue.

@anakin87 anakin87 reopened this Dec 21, 2023
@mathislucka mathislucka added the P1 High priority, add to the next sprint label Dec 22, 2023
@anakin87 anakin87 self-assigned this Dec 27, 2023
This was referenced Dec 27, 2023
Merged
Merged
Merged
@anakin87
Copy link
Member Author

Done in #6650 and deepset-ai/haystack-core-integrations#152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vblagoje vblagoje

@anakin87 anakin87

Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

changed metadata to meta sahusiddharth/haystack
changed metadata to meta sahusiddharth/haystack
5 participants
@masci @vblagoje @mathislucka @anakin87 @sahusiddharth