feat: Add meta_fields_to_embed to TransformersSimilarityRanker
#6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
2.x
sjrl
force-pushed
the
embed-metafields-ranker
branch
from
8fdc3ec to
cad09cd
Compare
sjrl
changed the title
metadata_fields_to_embed to TransformersSimilarityRankermeta_fields_to_embed to TransformersSimilarityRanker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add
metadata_fields_to_embedfollowing the implementation inSentenceTransformersDocumentEmbedderto be able to embed metadata fields along with the content of the document.How did you test it?
Added a new unit test to check the behavior. Updated existing tests for serializing the object.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.