Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change metadata to meta #152

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Change metadata to meta #152

merged 1 commit into from
Dec 28, 2023

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 requested a review from a team as a code owner December 27, 2023 17:10
@anakin87 anakin87 requested review from julian-risch and removed request for a team December 27, 2023 17:10
@vblagoje
Copy link
Member

@julian-risch you already have a bunch of PRs to review, lmk if its ok for me to take over this one.

@julian-risch julian-risch requested review from vblagoje and removed request for julian-risch December 28, 2023 11:01
vblagoje
vblagoje approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. If we missed anything (which I doubt), we can easily attend to it

@anakin87 anakin87 merged commit 21bc1c8 into main Dec 28, 2023
28 checks passed
@anakin87 anakin87 deleted the change-metadata-to-meta branch December 28, 2023 12:11
@anakin87 anakin87 mentioned this pull request Dec 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
integration:cohere integration:google-vertex integration:gradient integration:instructor-embedders integration:jina
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @vblagoje