-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace metadata w meta in tests/examples #6612
Conversation
@anakin87 Don't exclude the fix for the e2e tests:
The rag pipeline test shouldn't be broken at the moment. It's just the extractive qa pipeline that I need to update. |
I excluded them because they seem already broken for other reasons: https://github.com/deepset-ai/haystack/actions/runs/7287945256/job/19859716787 I would say we should fix them but not in this quick PR to make the CI green again |
I'd suggest including the fix to |
This reverts commit 1f91192.
@julian-risch it makes sense. I assigned you as reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 Good call to reopen the issue. I also see a couple of more places where .metadata is still used.
Related Issues
Proposed Changes:
metadata
tometa
#6570 is not complete. I'm reopening itHow did you test it?
CI
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.