Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace metadata w meta in tests/examples #6612

Merged
merged 3 commits into from
Dec 21, 2023
Merged

chore: replace metadata w meta in tests/examples #6612

merged 3 commits into from
Dec 21, 2023

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

How did you test it?

CI

Checklist

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Dec 21, 2023
@anakin87 anakin87 requested a review from a team as a code owner December 21, 2023 12:11
@anakin87 anakin87 requested review from ZanSara and removed request for a team December 21, 2023 12:11
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 labels Dec 21, 2023
@julian-risch
Copy link
Member

julian-risch commented Dec 21, 2023

@anakin87 Don't exclude the fix for the e2e tests:

rag_pipeline.connect("llm.metadata", "answer_builder.metadata")

The rag pipeline test shouldn't be broken at the moment. It's just the extractive qa pipeline that I need to update.

@anakin87
Copy link
Member Author

@anakin87 Don't forget e2e tests:

rag_pipeline.connect("llm.metadata", "answer_builder.metadata")

I excluded them because they seem already broken for other reasons: https://github.com/deepset-ai/haystack/actions/runs/7287945256/job/19859716787

I would say we should fix them but not in this quick PR to make the CI green again

@julian-risch
Copy link
Member

I'd suggest including the fix to rag_pipeline.connect("llm.metadata", "answer_builder.metadata") in this PR here. I understand that it triggers the e2e tests to run, which then fail due to the other issue. We could still merge the PR though. And I will fix the extractive qa e2e test by the end of the day.

@anakin87
Copy link
Member Author

anakin87 commented Dec 21, 2023

@julian-risch it makes sense.
I did not know that e2e tests are not required to merge.
Now I have made this change.

I assigned you as reviewer.

@anakin87 anakin87 requested review from julian-risch and removed request for ZanSara December 21, 2023 12:43
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Good call to reopen the issue. I also see a couple of more places where .metadata is still used.

@anakin87 anakin87 merged commit 7cc6080 into main Dec 21, 2023
21 of 22 checks passed
@anakin87 anakin87 deleted the rm-metadata branch December 21, 2023 13:09
@anakin87 anakin87 self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants