Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost dandischema to 0.10.1 which released 0.6.7 schema #1893

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

yarikoptic
Copy link
Member

without this now dandi-cli tests failing since would use fresh dandischema which would produce records in 0.6.7 schema. AFAIK, since just patch version increment probably no adjustment needed on dandi-archive side, but let's see if tests (and/or @satra or @bendichter) say otherwise

relevant change to schema:

and then also 0.10.0 had change to functionality:

but I hope (tests will show?) that this functionality was not used here

@yarikoptic yarikoptic added release Create a release when this pr is merged internal Changes only affect the internal API metadata Issues of dandiset/asset metadata handling labels Mar 19, 2024
@yarikoptic
Copy link
Member Author

yikes -- causes tests apocalypses. seems unrelated, filed:

@mvandenburgh
Copy link
Member

@yarikoptic if you rebase/merge off master the tests should start passing again.

without this now dandi-cli tests failing since would use fresh dandischema
which would produce records in 0.6.7 schema. AFAIK, since just patch version increment
probably no adjustment needed on dandi-archive side, but let's see if tests (and/or @satra or @bendichter) say otherwise
@yarikoptic
Copy link
Member Author

Great, thank you @mvandenburgh -- rebased

@yarikoptic
Copy link
Member Author

It is all green now and needs to be merged (attn @dandi/archive-maintainers )

@waxlamp waxlamp merged commit 8f8b7e6 into dandi:master Mar 21, 2024
11 checks passed
@dandibot
Copy link
Member

🚀 PR was released in v0.3.80 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Mar 21, 2024
@bendichter
Copy link
Member

It works!

image

@yarikoptic yarikoptic deleted the enh-boostschema branch July 10, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API metadata Issues of dandiset/asset metadata handling release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants