Do not allow dandischema 0.10.1 - new schema not yet supported by dandi-archive #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…di-archive With current release of dandi-schema our testing starts to fail, but dandi-archive seems needing CI fixing first to also make upgrade possible. So as a quick resolution to avoid ill effects on users etc, I think we should restrict version
yarikoptic
added
patch
jwodder
approved these changes
Mar 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1419 +/- ##
==========================================
+ Coverage 88.54% 88.62% +0.07%
==========================================
Files 77 77
Lines 10537 10537
==========================================
+ Hits 9330 9338 +8
+ Misses 1207 1199 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing started to fail
With current release of dandi-schema our testing starts to fail, but dandi-archive seems needing CI fixing first to also
make upgrade possible. So as a quick resolution to avoid ill effects on users etc, I think we should restrict version
refs: