Icon Improvements: ActionDelete & CheckmarkSolid

[ryanjwilke]

This PR introduces:

• Add more sizes for IconActionDelete
• Fix the colors for the IconCheckmarkSolid

[changeset-bot]

🦋 Changeset detected

Latest commit: 4f25fa9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@cypress-design/icon-registry	Patch
@cypress-design/react-icon	Patch
@cypress-design/vue-icon	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
cypress-design	✅ Ready (Inspect)	Visit Preview	Nov 16, 2023 0:11am

[cypress]

Passing run #1475 ↗︎

0

136

0

0

0

Details:

fix flake and enable retries
Project: cypress-design	Commit: 4f25fa9e87
Status: Passed	Duration: 02:34 💡
Started: Nov 16, 2023 12:14 PM	Ended: Nov 16, 2023 12:16 PM

Review all test suite changes for PR #343 ↗︎

[ryanjwilke]

@elevatebart It would appear this test is flaky, otherwise I'm not quite sure why it'd be failing: https://cloud.cypress.io/projects/89d3nq/runs/1472/overview?roarHideRunsWithDiffGroupsAndTags=1

Do we not have retries enabled? That would help resolve those issues quicker.

[elevatebart]

I am going to enable retries on this test specifically. Since it is the flaky one. Hopefully when we get a11y through cypress directly, we can skip the flake.

[elevatebart]

The change on the checkmark icon is a breaking change. Should we do that change, we have to check if this icon is used elsewhere.

[elevatebart]

I checked on both properties and the icon does not seem to be used.
We should be careful about this kind of "house-keeping" changes when they are not absolutely necessary.

[ryanjwilke]

@elevatebart Yeah, I was curious about the checkmark changes too. However, the API for that icon was very backwards when actually working with it. Light colors were dark, and dark colors were light. It was really confusing.