Icon Improvements: ActionDelete & CheckmarkSolid (#343)

* Added more IconActionDelete sizes and fixed colors for IconCheckmarkSolid * fix flake and enable retries --------- Co-authored-by: elevatebart <[email protected]>
cypress-io · Nov 16, 2023 · 2868018 · 2868018 · vercel · Nov 16, 2023
1 parent ffa15fb
commit 2868018
Show file tree

Hide file tree

Showing 8 changed files with 1,331 additions and 1,321 deletions.
diff --git a/.changeset/rare-boats-talk.md b/.changeset/rare-boats-talk.md
@@ -0,0 +1,7 @@
+---
+'@cypress-design/icon-registry': patch
+'@cypress-design/react-icon': patch
+'@cypress-design/vue-icon': patch
+---
+
+Added more IconActionDelete sizes and fixed the colors for the IconCheckmarkSolid
diff --git a/components/Button/vue/ButtonVue.cy.tsx b/components/Button/vue/ButtonVue.cy.tsx
@@ -29,7 +29,7 @@ describe('<Button />', { viewportHeight: 600, viewportWidth: 1000 }, () => {
   })
 
   it('responsively handles `disabled` changes', () => {
-    const disabled = ref(true)
+    const disabled = ref(false)
 
     mount({
       render: () => (
@@ -51,18 +51,14 @@ describe('<Button />', { viewportHeight: 600, viewportWidth: 1000 }, () => {
       ),
     })
 
-    // HTML & DS Buttons start off disabled
-    cy.findByTestId('html-button').should('be.disabled')
-    cy.findByTestId('ds-button').should('be.disabled')
+    cy.findByTestId('html-button').should('not.be.disabled')
+    cy.findByTestId('ds-button').should('not.be.disabled')
 
     // Click toggle button to update `ref` for `disabled` state
     cy.findByTestId('toggle').click()
 
-    // Base HTML button properly enables
-    cy.findByTestId('html-button').should('not.be.disabled')
-
-    // FAILS - DS Button stays disabled
-    cy.findByTestId('ds-button').should('not.be.disabled')
+    cy.findByTestId('html-button').should('be.disabled')
+    cy.findByTestId('ds-button').should('be.disabled')
   })
 
   it('responsively handles attributes changes', () => {

diff --git a/cypress.config.ts b/cypress.config.ts
@@ -10,6 +10,10 @@ export default defineConfig({
   fixturesFolder: false,
 
   component: {
+    retries: {
+      runMode: 2,
+      openMode: 0,
+    },
     setupNodeEvents(on) {
       on('task', {
         'a11y-table': function (message) {

diff --git a/icon-registry/icons/action-delete-small_x16.svg b/icon-registry/icons/action-delete-small_x16.svg
diff --git a/icon-registry/icons/action-delete-xsmall_x16.svg b/icon-registry/icons/action-delete-xsmall_x16.svg
diff --git a/icon-registry/icons/checkmark-solid_x16.svg b/icon-registry/icons/checkmark-solid_x16.svg
diff --git a/icon-registry/icons/checkmark-solid_x24.svg b/icon-registry/icons/checkmark-solid_x24.svg
diff --git a/yarn.lock b/yarn.lock