Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Improvements: ActionDelete & CheckmarkSolid #343

Merged
merged 2 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/rare-boats-talk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@cypress-design/icon-registry': patch
'@cypress-design/react-icon': patch
'@cypress-design/vue-icon': patch
---

Added more IconActionDelete sizes and fixed the colors for the IconCheckmarkSolid
14 changes: 5 additions & 9 deletions components/Button/vue/ButtonVue.cy.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('<Button />', { viewportHeight: 600, viewportWidth: 1000 }, () => {
})

it('responsively handles `disabled` changes', () => {
const disabled = ref(true)
const disabled = ref(false)

mount({
render: () => (
Expand All @@ -51,18 +51,14 @@ describe('<Button />', { viewportHeight: 600, viewportWidth: 1000 }, () => {
),
})

// HTML & DS Buttons start off disabled
cy.findByTestId('html-button').should('be.disabled')
cy.findByTestId('ds-button').should('be.disabled')
cy.findByTestId('html-button').should('not.be.disabled')
cy.findByTestId('ds-button').should('not.be.disabled')

// Click toggle button to update `ref` for `disabled` state
cy.findByTestId('toggle').click()

// Base HTML button properly enables
cy.findByTestId('html-button').should('not.be.disabled')

// FAILS - DS Button stays disabled
cy.findByTestId('ds-button').should('not.be.disabled')
cy.findByTestId('html-button').should('be.disabled')
cy.findByTestId('ds-button').should('be.disabled')
})

it('responsively handles attributes changes', () => {
Expand Down
4 changes: 4 additions & 0 deletions cypress.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ export default defineConfig({
fixturesFolder: false,

component: {
retries: {
runMode: 2,
openMode: 0,
},
setupNodeEvents(on) {
on('task', {
'a11y-table': function (message) {
Expand Down
3 changes: 3 additions & 0 deletions icon-registry/icons/action-delete-small_x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions icon-registry/icons/action-delete-xsmall_x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions icon-registry/icons/checkmark-solid_x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions icon-registry/icons/checkmark-solid_x24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2,613 changes: 1,305 additions & 1,308 deletions yarn.lock

Large diffs are not rendered by default.

Loading