Implement new MessageLogger configuration #32138
Conversation
This removes the need for the statistics vstring as the specification of directing the statistics to a given destination is done via the 'enableStatistics' bool parameter.
-Both the old and new configuration APIs are supported. Having `categories` and `destinations` parameters being available trigger the old configuration handling. -As much code as reasonably possible is shared between the two implementations. -The ParameterSetValidation code is used for the new API but the fillDescriptions usage can not be implemented until all uses of the old configuration are removed.
Properly read the 'files' PSet Set the correct default for lineLength Make it so the 'default' PSet can properly set the values for destinations which do not explicitly set a parameter.
-Properly handle setting up statistics -Set defaults to match original behavior -Throw an exception if multiple destinations want to write to the same log file
Only the tests which explicitly created the Service were changed. Those that use the standard cfi.py file must wait until we are ready to change that file.
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32138/19807
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32138/19808
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
The tests are being triggered in jenkins.
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32138/19903
|
|
Pull request #32138 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This adds support for using the new MessageLogger configuration syntax. The old syntax is also supported. The decision on which format to apply is based on the presence or absence of key parameters for each implementation.
The discussion about the new format can be found here: #31910
The new code makes use of the ParameterSet validation system to enforce correctness.
The standard MessageLogger_cfi.py configuration has not been updated to use the new configuration at this point since it would cause too many non framework configurations to break. That migration will happen at a later stage.
PR validation:
All framework unit tests have been updated to use the new syntax and they all pass.