-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated configurations in CalibCalorimetry to new MessageLogger syntax #32186
Updated configurations in CalibCalorimetry to new MessageLogger syntax #32186
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32186/19925
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CalibCalorimetry/CaloMiscalibTools @yuanchao, @christopheralanwest, @tocheng, @jmduarte, @cmsbuild, @rekovic, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
All configurations in CalibCalorimetry subsystem which explicitly create a MessageLogger have been converted to the new syntax.
PR validation:
All files were passed to
python
and no failures as a result of these change were seen.