Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new MessageLogger configuration #32138

Merged
merged 12 commits into from
Nov 19, 2020

Commits on Nov 6, 2020

  1. Specify use of statistics directly in destinations

    This removes the need for the statistics vstring as the specification of directing the statistics to a given destination is done via the 'enableStatistics' bool parameter.
    Dr15Jones committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    fdaa0f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9ed82a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f595d78 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Implement new MessageLogger configuration API

    -Both the old and new configuration APIs are supported. Having `categories` and `destinations` parameters being available trigger the old configuration handling.
    -As much code as reasonably possible is shared between the two implementations.
    -The ParameterSetValidation code is used for the new API but the fillDescriptions usage can not be implemented until all uses of the old configuration are removed.
    Dr15Jones committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    856130b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Fixed formatting

    Dr15Jones committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    292b6a2 View commit details
    Browse the repository at this point in the history
  2. Fix new configuration problems

    Properly read the 'files' PSet
    Set the correct default for lineLength
    Make it so the 'default' PSet can properly set the values for destinations which do not explicitly set a parameter.
    Dr15Jones committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    f16a78e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0c46ad0 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Correct problems when using new MessageLogger configuration

    -Properly handle setting up statistics
    -Set defaults to match original behavior
    -Throw an exception if multiple destinations want to write to the same log file
    Dr15Jones committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    130c1f4 View commit details
    Browse the repository at this point in the history
  2. Updated MessageLogger tests to use new configuration syntax

    Only the tests which explicitly created the Service were changed. Those that use the standard cfi.py file must wait until we are ready to change that file.
    Dr15Jones committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    a48efae View commit details
    Browse the repository at this point in the history
  3. code-checks update

    Dr15Jones committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    315a8f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Removed old code based on singleton pattern

    The ELadministrator has not been a singleton for a long time. The old code was preventing the use of std::make_shared with the class.
    Dr15Jones committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    d08b0be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cbec163 View commit details
    Browse the repository at this point in the history