Squash all Patatrack developments on top of CMSSW_11_3_0_pre5

[fwyzard]

This PR includes in a single commit all the Patatrack developments from the past years.

There are few ongoing issues, but this is good enough to start making the actual PRs.

I would ask all affected L2's to have a look at the changes in their packages, and suggest how they would like them to be split and organised.

Of course, any comments on the code itself are welcome !

[cmsbuild]

The code-checks are being triggered in jenkins.

[fwyzard]

@felicepantaleo @rovere @VinInn @makortel @vkhristenko @mariadalfonso @amassiro FYI

[fwyzard]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27983/11874

• This PR adds an extra 2020KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): Add EDProducers for mkFit #27895
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add EDProducers for mkFit #27895
  • File Configuration/PyReleaseValidation/python/relval_upgrade.py modified in PR(s): Add EDProducers for mkFit #27895
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Scenario2026D49: no Overlaps inside the Muon System and all MB4 Shiel… #27866, Add EDProducers for mkFit #27895
  • File Configuration/StandardSequences/python/RawToDigi_cff.py modified in PR(s): Select the unpacker to be run (between SCAL and MetaData) via Era modifier #27676
  • File EventFilter/Utilities/src/EvFDaqDirector.cc modified in PR(s): reintroduce missing lseek() for header-less files #27982
  • File HeterogeneousCore/MPICore/BuildFile.xml modified in PR(s): [RFC] - do not merge - edm::Wrapper<> de/serialisation #24389
  • File HeterogeneousCore/MPICore/interface/WrapperHandle.h modified in PR(s): [RFC] - do not merge - edm::Wrapper<> de/serialisation #24389
  • File HeterogeneousCore/MPICore/interface/serialization.h modified in PR(s): [RFC] - do not merge - edm::Wrapper<> de/serialisation #24389
  • File HeterogeneousCore/MPICore/src/serialization.cc modified in PR(s): [RFC] - do not merge - edm::Wrapper<> de/serialisation #24389
  • File RecoPixelVertexing/PixelTriplets/interface/CAHitQuadrupletGenerator.h modified in PR(s): [RFC] Cellular Automaton: Add hit-compatibility parameters tunable by layer triplets #27955
  • File Validation/RecoTrack/python/TrackValidation_cff.py modified in PR(s): add MTD related hits plots #27682
  • File Validation/RecoTrack/python/plotting/trackingPlots.py modified in PR(s): Add EDProducers for mkFit #27895

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2503/console Started: 2019/09/12 17:59

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

CUDADataFormats/BeamSpot
CUDADataFormats/Common
CUDADataFormats/EcalRecHitSoA
CUDADataFormats/SiPixelCluster
CUDADataFormats/SiPixelDigi
CUDADataFormats/Track
CUDADataFormats/TrackingRecHit
CUDADataFormats/Vertex
CalibTracker/Records
CalibTracker/SiPixelESProducers
CondFormats/SiPixelObjects
Configuration/Applications
Configuration/ProcessModifiers
Configuration/PyReleaseValidation
Configuration/StandardSequences
DQM/TrackingMonitorClient
DQM/TrackingMonitorSource
DQMOffline/Configuration
DQMOffline/RecoB
DataFormats/CaloRecHit
DataFormats/DetId
DataFormats/GeometrySurface
DataFormats/HcalDetId
DataFormats/HcalDigi
DataFormats/HcalRecHit
DataFormats/Math
DataFormats/SiPixelCluster
DataFormats/SiPixelDigi
EventFilter/SiPixelRawToDigi
EventFilter/Utilities
FWCore/Concurrency
FWCore/Utilities
FastSimulation/Tracking
Geometry/TrackerGeometryBuilder
HeterogeneousCore/CUDACore
HeterogeneousCore/CUDAServices
HeterogeneousCore/CUDATest
HeterogeneousCore/CUDAUtilities
HeterogeneousCore/MPICore
HeterogeneousCore/MPIServices
HeterogeneousCore/Producer
HeterogeneousCore/Product
RecoLocalCalo/EcalRecAlgos
RecoLocalCalo/EcalRecProducers
RecoLocalTracker/Configuration
RecoLocalTracker/SiPixelClusterizer
RecoLocalTracker/SiPixelRecHits
RecoPixelVertexing/Configuration
RecoPixelVertexing/PixelTrackFitting
RecoPixelVertexing/PixelTriplets
RecoPixelVertexing/PixelVertexFinding
RecoTracker/TkSeedGenerator
RecoVertex/BeamSpotProducer
SimTracker/TrackerHitAssociation
Utilities/ReleaseScripts
Validation/RecoTrack

The following packages do not have a category, yet:

CUDADataFormats/BeamSpot
CUDADataFormats/Common
CUDADataFormats/EcalRecHitSoA
CUDADataFormats/SiPixelCluster
CUDADataFormats/SiPixelDigi
CUDADataFormats/Track
CUDADataFormats/TrackingRecHit
CUDADataFormats/Vertex
HeterogeneousCore/CUDACore
HeterogeneousCore/CUDATest
HeterogeneousCore/CUDAUtilities
HeterogeneousCore/MPICore
HeterogeneousCore/MPIServices
HeterogeneousCore/Producer
HeterogeneousCore/Product
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@andrius-k, @lveldere, @chayanit, @emeschi, @sbein, @schneiml, @ianna, @kpedro88, @ggovi, @fioriNTU, @tlampen, @pohsun, @perrotta, @civanch, @zhenhu, @cmsbuild, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @slava77, @mommsen, @fabiocos, @ssekmen, @kmaeshima, @christopheralanwest, @pgunnell, @franzoni can you please review it and eventually sign? Thanks.
@echabert, @emilbols, @felicepantaleo, @yduhm, @argiro, @HeinerTholen, @mschrode, @fioriNTU, @threus, @mmusich, @seemasharmafnal, @venturia, @hdelanno, @makortel, @smoortga, @acaudron, @apsallid, @ferencek, @rociovilar, @pieterdavid, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @jandrea, @alesaggio, @idebruyn, @ebrondol, @mtosi, @dgulhan, @Martin-Grunewald, @gbenelli, @wddgit, @JyothsnaKomaragiri, @mverzett, @dkotlins, @wmtford, @gpetruc, @matt-komm, @mariadalfonso, @pvmulder, @andrzejnovak this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: b1965c2

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c28630/2503/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency ClangBuild

• Build:

I found compilation warning when building: See details on the summary page.

• Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-09-11-2300/src/HeterogeneousCore/CUDAUtilities/test/test_GPUSimpleVector.cu 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-09-11-2300/src/HeterogeneousCore/CUDAUtilities/test/OneToManyAssoc_t.cpp 
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-09-11-2300/src/HeterogeneousCore/CUDAUtilities/test/OneToManyAssoc_t.cpp:1:
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-09-11-2300/src/HeterogeneousCore/CUDAUtilities/test/OneToManyAssoc_t.h:14:
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-09-11-2300/src/HeterogeneousCore/CUDAUtilities/interface/HistoContainer.h:20:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-09-11-2300/src/HeterogeneousCore/CUDAUtilities/interface/prefixScan.h:142:30: error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare]
    isLastBlockDone = (value == (gridDim.x - 1));
                       ~~~~~ ^   ~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-09-11-2300/src/HeterogeneousCore/CUDAUtilities/interface/prefixScan.h:154:31: error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare]
  for (int i = threadIdx.x; i < gridDim.x; i += blockDim.x) {
                            ~ ^ ~~~~~~~~~


[silviodonato]

@fwyzard can we finally close this PR?

[fwyzard]

I think so - most changes are in CMSSW_11_3_0_pre6.