Split SiPixelCalSingleMuon into two separate ALCARECO producers

[mmusich]

PR description:

Several times, an excessive disk resource usage from ALCARECOs has been pointed out, especially when it comes to pixel clusters, since the information is replicated many times over many datasets (Alignment, Strips, Pixel & Lumi ALCA flavours).
For what concerns the SiPixelCalSingleMuon, introduced in PR #28535:

• we don’t really need 100% of the tracks in the event to produce performance measurements:
  • e.g. for Lorentz Angle monitoring, a prescale factor 100 seems to still yield reasonable results (see earlier results from Wei Wei here, here and here)
• as we are not saving the off-track pixel clusters, it is not possible to perform e.g. hit efficiency measurement in an unbiased way directly with the ALCARECO.
  • though it is possible to re-create them on-the-fly from RAW by using the two-file solution → cumbersome!

Proposal for reduction:

• the SiPixelCalSingleMuon is to be split and two new producers created:
  • one called SiPixelCalSingleMuonLoose (with same event and track selection as presently implemented), but running prescaled of a factor 100. This is targeted to the cluster properties measurements + Pixel LA measurement @ PCL;
  • one called SiPixelCalSingleMuonTight which runs on all events without prescales, but with tighter cuts, targeted to hit efficiency measurement. Saving:
    • Only the muon tracks (+ on-track pixel & strip clusters), to be able to refit them
    • The off-track clusters closer to the muon trajectory crossings with the pixel layers (disks).

The last point is implemented by introducing a new producer NearbyPixelClustersProducer which saves in the event a new Pixel Cluster collection, made up of all the pixel clusters which are either:

• the single closest ones to the muon track trajectory crossings
• the whole set of clusters on the same DetId of the trajectory crossing;

The new collection is called closebyPixelClusters.
This proposal has been presented at the Pixel DPG meeting of Apr 7th, 2021 and endorsed there.

PR validation:

Tested to be technically running on 2018 data with:

cmsDriver.py -s RAW2DIGI,RECO,ALCA:SiPixelCalSingleMuonLoose+SiPixelCalSingleMuonTight \
--conditions auto:run2_data \
--eventcontent=ALCARECO \
--datatier ALCARECO \
-n -1 \
--no_exec --era Run2_2018 \
--python_filename=SingleMuonCombined_2018.py \
--nThreads=8 \
--filein=root://cms-xrd-global.cern.ch//store/data/Run2018C/SingleMuon/RAW/v1/000/320/065/00000/F43017EB-328E-E811-B679-FA163E6314D2.root

The average event size evaluated on ~3500 of 2018C data (for run 320065) is:

ALCARECO	< evt size > [kB]
SiPixelCalSingleMuon	14.12
SiPixelCalSingleMuonLoose	14.12 (prescale x 100)
SiPixelCalSingleMuonTight	8.35

✔️ We can foresee a reduction of ~ 1/2 of the data size with these changes.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport, no backport is needed.

cc:
@tvami

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33399/22022

• This PR adds an extra 136KB to repository

• Found files with invalid states:

  • Calibration/TkAlCaRecoProducers/plugins/NearbyPixelClusterProducer.cc:
    • Added: ca7a38d
    • Modified: 3ba2e1c
    • Deleted: 576d118

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/EventContent/python/AlCaRecoOutput_cff.py modified in PR(s): [PPS] Prompt calibration loop component for timing detector #33215
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Patatrack integration - Pixel workflows (12/N) #31854, Add customisation to make sure that upgrade WFs will cross LS in the short matrix  #32957, [PPS] Prompt calibration loop component for timing detector #33215, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File Configuration/StandardSequences/python/AlCaRecoStreams_cff.py modified in PR(s): [PPS] Prompt calibration loop component for timing detector #33215

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers
Configuration/AlCa
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences

@malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @christopheralanwest, @srimanob, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @tlampen, @qliphy, @pohsun, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tocheng, @lecriste, @threus, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e518c/14157/summary.html
COMMIT: 43d60b9
CMSSW: CMSSW_11_3_X_2021-04-11-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33399/14157/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33399/22023

• This PR adds an extra 144KB to repository

• Found files with invalid states:

  • Calibration/TkAlCaRecoProducers/plugins/NearbyPixelClusterProducer.cc:
    • Added: ca7a38d
    • Modified: 3ba2e1c
    • Deleted: 576d118

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/EventContent/python/AlCaRecoOutput_cff.py modified in PR(s): [PPS] Prompt calibration loop component for timing detector #33215
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Patatrack integration - Pixel workflows (12/N) #31854, Add customisation to make sure that upgrade WFs will cross LS in the short matrix  #32957, [PPS] Prompt calibration loop component for timing detector #33215, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File Configuration/StandardSequences/python/AlCaRecoStreams_cff.py modified in PR(s): [PPS] Prompt calibration loop component for timing detector #33215

[cmsbuild]

Pull request #33399 was updated. @malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @christopheralanwest, @srimanob, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @tlampen, @qliphy, @pohsun, @francescobrivio, @fabiocos, @davidlange6 can you please check and sign again.

[mmusich]

code-checks

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e518c/14224/summary.html
COMMIT: 3e85054
CMSSW: CMSSW_11_3_X_2021-04-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33399/14224/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865526
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2865502
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.078 KiB( 37 files compared)
• DQMHistoSizes: changed ( 1000.0 ): 0.039 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 1000.0 ): 0.039 KiB MessageLogger/Errors
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[chayanit]

+1

[srimanob]

+Upgrade

[mmusich]

@yuanchao can you please review and sign again?

[yuanchao]

+1

[mmusich]

ping @cms-sw/operations-l2

[qliphy]

+operations

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1