Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex70 Add a new scenario D84 same as D70 but with updated tracker T24 #33454

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Apr 17, 2021

PR description:

Add a new scenario D84 same as D70 but with updated tracker T24 - to be used for testing Phase2 dd4hep. D83 is modified to use T24 instead of T21. T24 is identical to T21 but can be used for dd4hep as well as in ddd.

PR validation:

Use the runTheMatrix test workflows 37434.0 and 37834.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33454/22154

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData

@civanch, @Dr15Jones, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @kpedro88, @cmsbuild, @makortel, @franzoni, @silviodonato, @mdhildreth, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce6acb/14294/summary.html
COMMIT: 412f302
CMSSW: CMSSW_12_0_X_2021-04-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33454/14294/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877023
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

test parameters:

  • workflows = 37434.0, 37834.0

@srimanob
Copy link
Contributor

Please test

@srimanob
Copy link
Contributor

Hi @bsunanda
This PR is not to introduce D84 only, but also modify D83. Could you please update PR title and description?

  • IIUC, you need to see evolution of geometries with the same sub-detectors (work with dd4hep also) except HGCAL
  • Do you need also new detector with C15 + T24?

@bsunanda
Copy link
Contributor Author

T21 and T24 are identical except that T24 works for dd4hep while T21 does not. Since D83 is just introduced and there is no usage yet. I like to introduce the change as a bug fix. I am working on the validation package for D83 right now.

@bsunanda
Copy link
Contributor Author

We expect a new tracker version soon. Then we can introduce a new scenario - not before that.

@bsunanda
Copy link
Contributor Author

@srimanob Please look at the comments in this page. I have updated the description. T21 and T24 are identical except that T24 works for dd4hep while T21 does not. Since D83 is just introduced and there is no usage yet. I like to introduce the change as a bug fix. I am working on the validation package for D83 right now. We expect a new tracker version soon. Then we can introduce a new scenario.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce6acb/14300/summary.html
COMMIT: 412f302
CMSSW: CMSSW_12_0_X_2021-04-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33454/14300/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ce6acb/37434.0_TTbar_14TeV+2026D83+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ce6acb/37834.0_TTbar_14TeV+2026D84+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2877011
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

This PR is to

  • add new D84 geometry,
  • modify D83 to use T24, tracker geometry which works with DD4hep.
    Short matrix runs fine with workflows of D83 and D84.

@chayanit
Copy link

+1

@silviodonato
Copy link
Contributor

+operations

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 20, 2021

+1

@cmsbuild cmsbuild merged commit 8aa8d07 into cms-sw:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants