-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gex70 Add a new scenario D84 same as D70 but with updated tracker T24 #33454
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33454/22154
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @kpedro88, @cmsbuild, @makortel, @franzoni, @silviodonato, @mdhildreth, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce6acb/14294/summary.html Comparison SummarySummary:
|
test parameters:
|
Please test |
Hi @bsunanda
|
T21 and T24 are identical except that T24 works for dd4hep while T21 does not. Since D83 is just introduced and there is no usage yet. I like to introduce the change as a bug fix. I am working on the validation package for D83 right now. |
We expect a new tracker version soon. Then we can introduce a new scenario - not before that. |
@srimanob Please look at the comments in this page. I have updated the description. T21 and T24 are identical except that T24 works for dd4hep while T21 does not. Since D83 is just introduced and there is no usage yet. I like to introduce the change as a bug fix. I am working on the validation package for D83 right now. We expect a new tracker version soon. Then we can introduce a new scenario. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce6acb/14300/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade This PR is to
|
+1 |
+operations |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add a new scenario D84 same as D70 but with updated tracker T24 - to be used for testing Phase2 dd4hep. D83 is modified to use T24 instead of T21. T24 is identical to T21 but can be used for dd4hep as well as in ddd.
PR validation:
Use the runTheMatrix test workflows 37434.0 and 37834.0
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special