Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing-events proposal #126

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Testing-events proposal #126

merged 1 commit into from
Apr 26, 2023

Conversation

olensmar
Copy link
Contributor

@olensmar olensmar commented Apr 26, 2023

Changes

Adds a "Testing Events" bucket with corresponding subjects and predicates.

see previous PR for discussions - #105

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

@olensmar
Copy link
Contributor Author

@afrittoli @e-backmark-ericsson I recreated the PR with a single signed commit - hopefully that was the last hurdle..

@olensmar olensmar changed the title Recreated testing-events proposal with single commit Testing-events proposal Apr 26, 2023
@afrittoli
Copy link
Contributor

Thanks @olensmar - I made a git diff of the two branches and it looks good, only a minor change:

➜ git diff pr_105 pr_126
diff --git a/spec.md b/spec.md
index 6440086..5969c7d 100644
--- a/spec.md
+++ b/spec.md
@@ -516,4 +516,4 @@ platforms.
 [typesystem]: https://github.com/cloudevents/spec/blob/v1.0.2/cloudevents/spec.md#type-system
 [datacontenttype]: https://github.com/cloudevents/spec/blob/v1.0.2/cloudevents/spec.md#datacontenttype
 [rfc2406]: https://tools.ietf.org/html/rfc2046
-[purl-spec]: https://github.com/package-url/purl-spec/blob/master/PURL-SPECIFICATION.rst
+[purl-spec]: https://github.com/package-url/purl-spec/blob/master/PURL-SPECIFICATION.rst
\ No newline at end of file

Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this!

@afrittoli
Copy link
Contributor

@e-backmark-ericsson @xibz merging this PR as it was already approved in #105

@afrittoli afrittoli merged commit 7c639cd into cdevents:main Apr 26, 2023
@olensmar
Copy link
Contributor Author

thank you @afrittoli - looking forward to implementing these events!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants