Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The protocol is not consistent on events that notify executions #109

Open
e-backmark-ericsson opened this issue Jan 30, 2023 · 1 comment
Labels
breaking change Indicates when a PR or issue will have breaking changes roadmap Items on the roadmap
Milestone

Comments

@e-backmark-ericsson
Copy link
Contributor

e-backmark-ericsson commented Jan 30, 2023

This issue was raised as a result of a discussion during the CDEvents WG on Jan 30th, 2023

These event subjects all represent executions of some kind, as they can all be started and finished:

The protocol is not consistent regarding those subjects or their predicates though:

  • All of them have the predicates started and finished, but just some of them have the predicate queued
  • The names of the subjects sometimes contain the suffix "Run" and sometimes not. It makes somewhat sense to not add "Run" to a "build" subject, since a build can be interpreted as a verb, but the testCase and testSuite subjects should probably include the "Run" suffix to be consistent with taskRun and pipelineRun. A clear naming convention for events that represent executions should be written as well, to not end up in such inconsistencies ahead.

Furthermore, none of the subjects above have a predicate that would signal that the subject has left the queue. A subject that has been queued would eventually get started, but there seems to be a need to also be able to signal that the subject has been dequeued and thus is not anymore expected to be started. The predicate to use here should proposedly be either dequeued or canceled.

Note: Some of this issue is already considered in #105

@e-backmark-ericsson
Copy link
Contributor Author

Some of this was fixed in #126

We should try to fix the rest of it for 0.4

@e-backmark-ericsson e-backmark-ericsson added this to the v0.4 milestone Jun 5, 2023
@e-backmark-ericsson e-backmark-ericsson added the roadmap Items on the roadmap label Jun 5, 2023
@e-backmark-ericsson e-backmark-ericsson modified the milestones: v0.4, v0.5 Apr 2, 2024
@xibz xibz added the breaking change Indicates when a PR or issue will have breaking changes label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Indicates when a PR or issue will have breaking changes roadmap Items on the roadmap
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants