Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDEvents: Testkube Produces CDEvents #3681

Closed
TheBrunoLopes opened this issue Apr 13, 2023 · 5 comments · Fixed by #3806
Closed

CDEvents: Testkube Produces CDEvents #3681

TheBrunoLopes opened this issue Apr 13, 2023 · 5 comments · Fixed by #3806
Assignees

Comments

@TheBrunoLopes
Copy link
Member

TheBrunoLopes commented Apr 13, 2023

Read the CDEvents spec defined by @olensmar in this PRs https://github.com/cdevents/spec/pull/105/files
cdevents/spec#126
(feel free to add/suggest changes at your discretion)

It should be possible for external systems to receive/read these events.

cc: @olensmar @vsukhin to define how this integration should look like?

Questions to be answered:

  • How should external systems receive/read these events. Webhooks, subscribe to a message queue ? etc...
  • How should a user configure which events should be produced ? cc: @fivenp
@TheBrunoLopes TheBrunoLopes converted this from a draft issue Apr 13, 2023
@TheBrunoLopes TheBrunoLopes changed the title Testkube Produces CD Events CDEvents: Testkube Produces CDEvents Apr 13, 2023
@olensmar
Copy link
Member

My understanding is that we would POST these events using HTTP to a user-configurable endpoint - in line with the Cloud-Events HTTP Binding - https://github.com/cloudevents/spec/blob/main/cloudevents/bindings/http-protocol-binding.md

@fivenp
Copy link
Contributor

fivenp commented Apr 14, 2023

I'm not 100% sure if a user should be able to customise which events are going to be emitted by testkube – but rather just configure in their application / endpoint which one they want to listen/react to?

@olensmar
Copy link
Member

If the user configures an external endpoint I suggest we simply emit all events to start with..

@vsukhin vsukhin self-assigned this May 8, 2023
@vsukhin vsukhin moved this from 🔖 Ready to 🏗 In progress in Testkube May 9, 2023
@vsukhin vsukhin mentioned this issue May 10, 2023
6 tasks
@vsukhin vsukhin moved this from 🏗 In progress to 👀 In review in Testkube May 17, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Testkube May 18, 2023
@vsukhin vsukhin moved this from ✅ Done to QA in Testkube May 18, 2023
@exu
Copy link
Member

exu commented May 31, 2023

Usually it's a good practice to choose events which you want receive.
As getting all simply is not scaling well.
e.g. Stripe has almost 100 events, so getting all of them will be just wasting of compute resources.

@olensmar
Copy link
Member

agree @exu - i think the general idea is these events would get posted to an MQ that would further have rules regarding who they should be distributed to, as different components in a CD pipeline might have different needs.. i.e. we delegate this configuration to another component for now..

@vsukhin vsukhin moved this from QA to ✅ Done in Testkube Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants