-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cellfinder workflow CLI input argument with tests #23
Conversation
…signal and background files to None by default in dataclass (they need to be predefined).
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 0.00% 92.56% +92.56%
==========================================
Files 1 2 +1
Lines 5 121 +116
==========================================
+ Hits 0 112 +112
- Misses 5 9 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @sfmig
I think the source code looks good - made some minor comments!
As discussed, we may want to refactor the tests a bit in a separate PR.
A script to simulate a typical cellfinder workflow. It builds up on previous work from PRs #15 and #20 (none of which we merged).
We wanted
The current solution takes the path to a configuration json file as a command line input.
If no input json file is passed as a CLI argument, the default configuration defined at
brainglobe_workflows/cellfinder/default_config.json
is used. This default configuration fetches data from a GIN repo, creates a.cellfinder_workflows
cache subdirectory at the location the script is launched from, and saves to it the downloaded data and the output results.Example usage
cellfinder_main.py
parent directory:python cellfinder_main.py --config path/to/input/config.json
python cellfinder_main.py
It ended up being a larger PR than I thought, apologies! But hopefully it crystallises the structure we discussed these past few days (see #9)