This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
add parameter to make foot move further #283
Draft
SammyRamone
wants to merge
15
commits into
master
Choose a base branch
from
fix/kick_too_short
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on into fix/kick_too_short
16stelter
suggested changes
Nov 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not test this on my device, but apart from the few comments, lgtm
this works but needs tuning of parameters |
16stelter
previously approved these changes
Dec 14, 2021
needs to be restructured due to ROS2 change |
@timonegk should we reimplement/refactor this for ROS 2? |
Yes, at least the part of using the front of the foot for the target position should be kept. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Uses foot front part to compute kick, since it makes more sense
Adds better testing script
Adds some functionality to do splines in leg space because I tried that out, but removed it from the kick itself. Still would keep the changes for the splines if we want to do something like this in future.
Parameter are not optimized yet
Necessary checks
catkin build