Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

add parameter to make foot move further #283

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

SammyRamone
Copy link
Member

@SammyRamone SammyRamone commented Jun 21, 2021

Proposed changes

Uses foot front part to compute kick, since it makes more sense
Adds better testing script
Adds some functionality to do splines in leg space because I tried that out, but removed it from the kick itself. Still would keep the changes for the splines if we want to do something like this in future.
Parameter are not optimized yet

Necessary checks

  • Update package version
  • Run catkin build
  • Write documentation
  • Create issues for future work
  • Test on your machine
  • Test on the robot
  • Put the PR on our Project board

@SammyRamone SammyRamone requested a review from timonegk June 21, 2021 10:51
@SammyRamone SammyRamone self-assigned this Jun 21, 2021
@SammyRamone SammyRamone requested a review from Flova June 21, 2021 10:52
Copy link

@16stelter 16stelter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not test this on my device, but apart from the few comments, lgtm

bitbots_dynamic_kick/scripts/dummy_client.py Outdated Show resolved Hide resolved
bitbots_dynamic_kick/scripts/interactive_test.py Outdated Show resolved Hide resolved
bitbots_dynamic_kick/scripts/interactive_test.py Outdated Show resolved Hide resolved
bitbots_dynamic_kick/src/kick_engine.cpp Outdated Show resolved Hide resolved
bitbots_dynamic_kick/src/kick_node.cpp Show resolved Hide resolved
@SammyRamone SammyRamone requested a review from 16stelter December 9, 2021 16:08
@SammyRamone
Copy link
Member Author

this works but needs tuning of parameters

16stelter
16stelter previously approved these changes Dec 14, 2021
@SammyRamone
Copy link
Member Author

needs to be restructured due to ROS2 change

@jaagut jaagut marked this pull request as draft December 2, 2022 14:09
@jaagut
Copy link
Member

jaagut commented Sep 4, 2023

@timonegk should we reimplement/refactor this for ROS 2?

@timonegk
Copy link
Member

timonegk commented Sep 4, 2023

Yes, at least the part of using the front of the foot for the target position should be kept.

@jaagut jaagut self-assigned this Sep 4, 2023
@SammyRamone SammyRamone removed their assignment Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants