-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lanelet2_extension): update documentation for bus_stop_area to be introduced in format_version2 #21
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 15.84% 15.84%
=======================================
Files 40 40
Lines 2765 2765
Branches 1348 1348
=======================================
Hits 438 438
Misses 2239 2239
Partials 88 88
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can separate this PR into following 3 PRs to review easily.
- Implement BusStopArea class and modify CMakeLists.txt
- Update format version namespace
- Update documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to fix typo at least.
https://github.com/autowarefoundation/autoware_lanelet2_extension/actions/runs/10452523480/job/28941120917?pr=21
@youtalk All right, I will update the document at first in this PR ! |
…e(format_version2) Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
There are 5 typos. You fixed only one of them.
|
Signed-off-by: Mamoru Sobue <[email protected]>
typos have been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you made a force push. I just saw the commit 38903c9.
The documentation update is the 3rd step. I will review again after 1st and 2nd steps merged.
You can separate this PR into following 3 PRs to review easily.
- Implement BusStopArea class and modify CMakeLists.txt
- Update format version namespace
- Update documentation
OK, then I will first make this PR ready: It adds BusStopArea implementation in format_v2, but format_v1 still remains the default. Then this PR releases format_v2 and I'm running T4 E2E test now. I prefer bringing #23 PR last because it upgrades the API version. |
Is it possible to split the PR to addition of bus_stop_area and bicycle_lane with the rest of refactoring of the documentation? |
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your cooperation to split PRs. It's very easy to review them.
LGTM
Description
add the documentation for description and specification for bus_stop_area and bicycle_lane
https://github.com/orgs/autowarefoundation/discussions/5097
Related links
https://github.com/orgs/autowarefoundation/discussions/5097
Tests performed
documentation PR
Notes for reviewers
Interface changes
added new map primitives
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.