Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge feat(lanelet2_extension)!: release format_v2 #23

Closed
wants to merge 8 commits into from

Conversation

soblin
Copy link
Collaborator

@soblin soblin commented Aug 20, 2024

Description

depends

Related links

https://github.com/orgs/autowarefoundation/discussions/5097

Tests performed

https://evaluation.tier4.jp/evaluation/reports/34b3f105-e857-55e0-af53-d7e0e6413126?project_id=prd_jt

Notes for reviewers

Interface changes

Autoware Lanelet2 Map with BusStopArea regulatory element has to be format_version=2

  • Since the inline namespace has changed from format_v1 to format_v2, ABI compatibility is broken
    • if dependent projects have been exploiting previous version of autoware_lanelet2_extension shared library via apt or submodules, and updated autoware_lanelet2_extension library, then the clients need to rebuild their projects
  • Backward compatibility for Autoware Lanelet2 Map is fully ensured:
    • clients using autoware_lanelet2_extension>=0.6.0 can still fully use Autoware Lanelet2 Map with format version <= 2.
  • Forward compatibility is not ensured:
    • Autoware and clients using autoware_anelet2_extension<0.6.0 can not load Autoware Lanelet2 Map@format_version=2 and fails as follows
[map_projection_loader_node-26] Errors ocurred while parsing Lanelet Map:
[map_projection_loader_node-26]         - Error parsing primitive xxx: Creating a regulatory element of type bus_stop_area failed: No regulatory element found that implements rule bus_stop_area
[map_projection_loader_node-26]         - Error parsing primitive xxx: Failed to get id xxx from map

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.48%. Comparing base (5e09dc7) to head (f912a14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   16.48%   16.48%           
=======================================
  Files          42       42           
  Lines        2808     2808           
  Branches     1371     1371           
=======================================
  Hits          463      463           
  Misses       2252     2252           
  Partials       93       93           
Flag Coverage Δ *Carryforward flag
differential 16.48% <ø> (-0.26%) ⬇️
total 16.48% <ø> (ø) Carriedforward from 5e09dc7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin changed the title feat!(lanelet2_extension): release format_v2 feat(lanelet2_extension)!: release format_v2 Aug 20, 2024
@soblin soblin force-pushed the feat/release-format-v2 branch 3 times, most recently from f8444dd to f963322 Compare August 26, 2024 02:56
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin force-pushed the feat/release-format-v2 branch 2 times, most recently from db9fc95 to 3f55410 Compare August 26, 2024 08:08
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin marked this pull request as ready for review August 27, 2024 08:32
@soblin soblin changed the title feat(lanelet2_extension)!: release format_v2 do not merge feat(lanelet2_extension)!: release format_v2 Aug 27, 2024
@soblin
Copy link
Collaborator Author

soblin commented Aug 27, 2024

I can not understand why I see ./doc diffs although this branch has the same content as the main branch in the directory.

@soblin soblin closed this Aug 27, 2024
@soblin soblin deleted the feat/release-format-v2 branch August 28, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant