-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lanelet2_extension)!: release format_v2 #26
Conversation
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
…e(format_version2) Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 16.48% 16.48%
=======================================
Files 42 42
Lines 2808 2808
Branches 1371 1371
=======================================
Hits 463 463
Misses 2252 2252
Partials 93 93
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
depends
Related links
https://github.com/orgs/autowarefoundation/discussions/5097
Tests performed
https://evaluation.tier4.jp/evaluation/reports/43305b3f-7b12-5d9d-9170-2a19c2bcb1d2?project_id=prd_jt
Notes for reviewers
Interface changes
Autoware Lanelet2 Map with
BusStopArea
regulatory element has to beformat_version=2
format_v1
toformat_v2
, ABI compatibility is brokenautoware_lanelet2_extension
shared library viaapt
or submodules, and updatedautoware_lanelet2_extension
library, then the clients need to rebuild their projectsautoware_lanelet2_extension>=0.5.0
can still fully use Autoware Lanelet2 Map with format version <= 2.autoware_anelet2_extension<0.5.0
can not load Autoware Lanelet2 Map@format_version=2 and fails as followsEffects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.