Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port autoware_geography_utils from autoware.universe #100

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Nov 14, 2024

Description

This ports autoware_geography_utils from Autoware.Universe

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Nov 14, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 33 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@0b33221). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../autoware_geography_utils/test/test_projection.cpp 74.13% 0 Missing and 15 partials ⚠️
...utoware_geography_utils/src/lanelet2_projector.cpp 50.00% 8 Missing and 1 partial ⚠️
...mmon/autoware_geography_utils/test/test_height.cpp 72.22% 0 Missing and 5 partials ⚠️
common/autoware_geography_utils/src/height.cpp 77.77% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage        ?   76.92%           
=======================================
  Files           ?        6           
  Lines           ?      143           
  Branches        ?       55           
=======================================
  Hits            ?      110           
  Misses          ?       12           
  Partials        ?       21           
Flag Coverage Δ
differential 76.92% <76.92%> (?)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@youtalk youtalk requested a review from Copilot December 4, 2024 08:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 12 changed files in this pull request and generated no suggestions.

Files not reviewed (11)
  • common/autoware_geography_utils/CMakeLists.txt: Language not supported
  • common/autoware_geography_utils/include/autoware/geography_utils/height.hpp: Language not supported
  • common/autoware_geography_utils/include/autoware/geography_utils/lanelet2_projector.hpp: Language not supported
  • common/autoware_geography_utils/include/autoware/geography_utils/projection.hpp: Language not supported
  • common/autoware_geography_utils/package.xml: Language not supported
  • common/autoware_geography_utils/src/height.cpp: Language not supported
  • common/autoware_geography_utils/src/lanelet2_projector.cpp: Language not supported
  • common/autoware_geography_utils/src/projection.cpp: Language not supported
  • common/autoware_geography_utils/test/test_geography_utils.cpp: Language not supported
  • common/autoware_geography_utils/test/test_height.cpp: Language not supported
  • common/autoware_geography_utils/test/test_projection.cpp: Language not supported
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that the package was cut and pasted only with the following modifications:

  • changelog.rst
  • package.xml

Source:

Target:

This should not break any existing configuration as long as we also make sure the autoware main repo points to the correct versions of core and universe.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to port a package from autoware.universe by git subtree split to maintain the commit history.

https://docs.github.com/en/get-started/using-git/splitting-a-subfolder-out-into-a-new-repository
https://git-memo.readthedocs.io/en/latest/subtree.html

common/autoware_geography_utils/README.md Show resolved Hide resolved
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed #103 and realized that the copy has superior points in comparison with maintaining the history, so I am changing my opinion.

@youtalk
Copy link
Member

youtalk commented Dec 5, 2024

The cppcheck-differential worked correctly.
https://github.com/autowarefoundation/autoware.core/actions/runs/12172221820/job/33950507688?pr=100#step:13:1
But since this PR is a porting purpose. We don't need to modify here.

@mitsudome-r mitsudome-r merged commit dee0966 into autowarefoundation:main Dec 5, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants