-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port autoware_geography_utils from autoware.universe #100
feat: port autoware_geography_utils from autoware.universe #100
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
623d86b
to
17e1e85
Compare
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
17e1e85
to
54ea3cc
Compare
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage ? 76.92%
=======================================
Files ? 6
Lines ? 143
Branches ? 55
=======================================
Hits ? 110
Misses ? 12
Partials ? 21
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 12 changed files in this pull request and generated no suggestions.
Files not reviewed (11)
- common/autoware_geography_utils/CMakeLists.txt: Language not supported
- common/autoware_geography_utils/include/autoware/geography_utils/height.hpp: Language not supported
- common/autoware_geography_utils/include/autoware/geography_utils/lanelet2_projector.hpp: Language not supported
- common/autoware_geography_utils/include/autoware/geography_utils/projection.hpp: Language not supported
- common/autoware_geography_utils/package.xml: Language not supported
- common/autoware_geography_utils/src/height.cpp: Language not supported
- common/autoware_geography_utils/src/lanelet2_projector.cpp: Language not supported
- common/autoware_geography_utils/src/projection.cpp: Language not supported
- common/autoware_geography_utils/test/test_geography_utils.cpp: Language not supported
- common/autoware_geography_utils/test/test_height.cpp: Language not supported
- common/autoware_geography_utils/test/test_projection.cpp: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that the package was cut and pasted only with the following modifications:
- changelog.rst
- package.xml
Source:
Target:
This should not break any existing configuration as long as we also make sure the autoware main repo points to the correct versions of core and universe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to port a package from autoware.universe
by git subtree split
to maintain the commit history.
https://docs.github.com/en/get-started/using-git/splitting-a-subfolder-out-into-a-new-repository
https://git-memo.readthedocs.io/en/latest/subtree.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed #103 and realized that the copy has superior points in comparison with maintaining the history, so I am changing my opinion.
The |
Description
This ports autoware_geography_utils from Autoware.Universe
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.