-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoware_geography_utils from autoware.universe with history #103
Conversation
… (#7790) * refactor(geography_utils): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]> * move headers to include/autoware/ Signed-off-by: Esteve Fernandez <[email protected]> --------- Signed-off-by: Esteve Fernandez <[email protected]>
* update maintainers Signed-off-by: Yamato Ando <[email protected]> * add author Signed-off-by: Yamato Ando <[email protected]> --------- Signed-off-by: Yamato Ando <[email protected]>
* unify package.xml version to 0.37.0 * remove system_monitor/CHANGELOG.rst * add changelog * 0.38.0 --------- Signed-off-by: Yutaka Kondo <[email protected]>
…on/autoware.universe (#9304) Signed-off-by: Esteve Fernandez <[email protected]>
…Info (#9392) Signed-off-by: Ryohsuke Mitsudome <[email protected]>
This keeps the commits intact but most of the reasoning is within the actual PR links. Maybe it's better to have it merged without the history. Because the history before moving to this repo can be best traversed within the original universe repository. And the links in the commit titles (like feat!: replace tier4_map_msgs with autoware_map_msgs for MapProjectorInfo (#9392) ) I'd prefer to merge as a fresh package like in: EDIT: |
Also @youtalk -san, I didn't need to use Shared my steps in the description above. Did I achieve the end result you were proposing here? Commits of this PR: https://github.com/autowarefoundation/autoware.core/pull/103/commits |
@xmfcx I believe that the commit history should still be preserved despite the inconsistencies in links and renaming the package. Since we basically use squash merges, the link issue isn’t much of a problem. I think being able to trace the history from the descriptions of this commit or this PR are valuable. Ref. |
Changelog for package autoware_geography_utils | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
0.38.0 (2024-11-08) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to maintain the commit history, we’ll need to add a commit to reassign version numbers. This is troublesome. As @xmfcx suggested, copying might be a better option...
I’m grateful for your consideration ❤️ People can trace back from these PRs back to Universe, that should suffice 👍 |
Description
This is a test PR.
Reference: feat: port autoware_geography_utils from autoware.universe #100 (review)
Simple version: feat: port autoware_geography_utils from autoware.universe #100
I've ran these commands:
a fresh clone
and pushed.
This kept the commits that contributed to this package intact and rebased on top of the main.
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.