Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github): change suppression options in cppcheck-differencial check #106

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 5, 2024

Description

This PR adjusts the suppression options to match those of cppcheck-weekly in order to fix the cppcheck-differential errors.
https://github.com/autowarefoundation/autoware.core/actions/runs/12141461331/job/33949340069?pr=100#step:11:9

It is stricter than the one used in autoware.universe.
https://github.com/autowarefoundation/autoware.universe/blob/main/.cppcheck_suppressions

After merging this PR, we would like to set the cppcheck-differential as a required check.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Yutaka Kondo <[email protected]>
Copy link

github-actions bot commented Dec 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk changed the title chore(.github): change suppression options from cppcheck-differencial check chore(.github): change suppression options in cppcheck-differencial check Dec 5, 2024
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal. LGTM

@youtalk youtalk enabled auto-merge (squash) December 5, 2024 02:33
@youtalk youtalk merged commit 0b33221 into main Dec 5, 2024
30 checks passed
@youtalk youtalk deleted the remove-cppcheck-supressions branch December 5, 2024 02:36
youtalk added a commit that referenced this pull request Dec 6, 2024
youtalk added a commit that referenced this pull request Dec 6, 2024
* add file

Signed-off-by: Yutaka Kondo <[email protected]>

* Revert "chore(.github): change suppression options in `cppcheck-differencial` check (#106)"

This reverts commit 0b33221.

---------

Signed-off-by: Yutaka Kondo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants