Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set float64 #39

Merged
merged 5 commits into from
May 16, 2023
Merged

Set float64 #39

merged 5 commits into from
May 16, 2023

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented May 8, 2023

This PR hopefully fixes "random" failing tests with Jax and Pytorch.
See:

This is a preliminary solution, see #42.

@Giulero Giulero self-assigned this May 8, 2023
@Giulero Giulero requested a review from traversaro May 8, 2023 13:00
@traversaro
Copy link
Contributor

I tried to apply this in the conda-forge PR (see traversaro/staged-recipes@e20e773 and traversaro/staged-recipes@6d839a1) to see if this fixes the failure.

@traversaro
Copy link
Contributor

traversaro commented May 8, 2023

@Giulero
Copy link
Collaborator Author

Giulero commented May 8, 2023

That really mysterious 😨
I don't understand. In gravity_term, the only difference with bias_forces is that the robot velocity is zero. What can it be?

@Giulero Giulero reopened this May 16, 2023
@Giulero
Copy link
Collaborator Author

Giulero commented May 16, 2023

Thanks @traversaro!

@Giulero Giulero merged commit e324e03 into main May 16, 2023
@Giulero Giulero deleted the to-float-type branch May 16, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants