[Bugfix] Cleanup tool: Add balance check #2295
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
| amount: budgeted - balance, | ||
| }); | ||
| num_sources += 1; | ||
| if (balance > 0) { |
There was a problem hiding this comment.
Would it make sense to have this be >= so that way exact zeros just act like normal and don't get the warning message?
|
This all functionally makes sense. Could you make the notifications not be errors, but be warnings? |
|
I'm not sure how to pass both "ok" and "warning" messages. There is at least one situation where you can get the "Successfully returned funds from" message but there are also warnings that some categories did not have funds. For the moment, I opted to ignore those warnings... but only because I don't know how to pass both types out. |
shall0pass
changed the title
|
@youngcw I had some merge conflicts. This'll need one last look. Thanks! |
trafico-bot
bot
added
✨ Merged
* add balance check * lint * fill rollover categories after non-rollover * allow partial fills of non-rollover * update * release note and youngcw suggestion * warnings * remove commented coded
Resolves #2294
2024-01-28-My-Finances-2-0db6faf.zip