[Bug]: End of month cleanup should ignore rollover categories

[kymckay]

Verified issue does not already exist?

• I have searched and found no existing issue

Is this related to GoCardless, Simplefin or another bank-sync provider?

• I have checked my server logs and could not see any errors there
• I will be attaching my server logs to this issue
• I will be attaching my client-side (browser) logs to this issue
• I understand that this issue will be automatically closed if insufficient information is provided

What happened?

1. Overspend a category and set it to roll over.
2. Add #cleanup source to the category.
3. Create another category with #cleanup sink.
4. Run end of month clean up. The overspend is covered by putting the sink category into overspend instead.

Perhaps this is desirable? I can't decide, but it didn't feel intuitive to me since I explicitly set the overspend to roll over. With the intention of covering it with reimbursement the following month.

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

[shall0pass]

I see what you're saying. And I think the behavior exists for both rollover and non-rollover categories.

I could potentially see a use case to change add a negative value to a rollover category to fund another category. Specifically, I'm thinking about a 'credit debt' type category. But I think I agree with you that maybe shouldn't be the default behavior but could possibly be specified by a flag.

We can and should add a check for 'source' categories to make sure the balance is positive before taking money from it.

[shall0pass]

@kymckay Would you mind trying #2295 . I added additional logic for rollover categories (where the documentation would need to be changed), so I could remove that if it breaks peoples workflows.