Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[End of Month Cleanup] Remove automatic funding of rollover categories #2409

Merged

Conversation

shall0pass
Copy link
Contributor

#2295 introduced the logic to automatically fund rollover categories after non-rollover categories and before utilizing the sink categories. This PR reverts that logic. The documentation will be amended to recommend using the 'sink' term on rollover balance categories if the desire is to fund those categories. This approach allows both workflows.

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit a3d4f37
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65e2157e1f58480008242e80
😎 Deploy Preview https://deploy-preview-2409.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.47 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/narrow.js 79.85 kB 0%
static/js/wide.js 267.47 kB 0%
static/js/ReportRouter.js 1.21 MB 0%
static/js/index.js 2.74 MB 0%

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB → 1.2 MB (-508 B) -0.04%
Changeset
File Δ Size
packages/loot-core/src/server/budget/cleanup-template.ts 📉 -1.3 kB (-15.44%) 8.42 kB → 7.12 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.2 MB → 1.2 MB (-508 B) -0.04%

Unchanged

No assets were unchanged

Copy link
Member

@youngcw youngcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shall0pass shall0pass merged commit 601c9aa into actualbudget:master Mar 4, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Mar 4, 2024
shall0pass added a commit to actualbudget/docs that referenced this pull request Mar 4, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
actualbudget#2409)

* remove automatic funding of rollover categories

* note
@shall0pass shall0pass deleted the cleanup_rollovercategories branch March 15, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants