♻️ (typescript) enable strict mode everywhere

[MatissJanis]

Fixing all the issues that keep coming in from new PRs is like swimming against the tide. Instead of continuing with that approach: I'm enabling strict mode everywhere. And then explicitly disabling in the files where it breaks (these need to be fixed still).

This ensures that all new files created will follow TS strict mode.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	356cfcc
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/65a442f6b13b750008a14a5a
😎 Deploy Preview	https://deploy-preview-2230.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.08 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74-bhyX5Ad6.js	13.5 kB	0%
static/js/resize-observer-6FaCDon1.js	18.37 kB	0%
static/js/BackgroundImage-SinEaH_n.js	122.29 kB	0%
static/js/ButtonLink-EX8Rc8ei.js	379 B	0%
static/js/BalanceTooltip-UwWirK_r.js	6.07 kB	0%
static/js/FiltersMenu-FCXTliQP.js	28.92 kB	0%
static/js/narrow-c3J4zwWM.js	82.17 kB	0%
static/js/wide-fQM9kMtE.js	238.99 kB	0%
static/js/ReportRouter-6Yb6g6gJ.js	1.95 MB	0%
static/js/index-_yXEToBT.js	2.63 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.23 MB	0%

Changeset

File	Δ	Size
packages/loot-core/src/server/spreadsheet/util.ts	📈 +21 B (+6.21%)	338 B → 359 B
packages/loot-core/src/server/budget/util.ts	📈 +21 B (+3.65%)	576 B → 597 B
packages/loot-core/src/server/sync/make-test-message.ts	📈 +21 B (+3.65%)	576 B → 597 B
packages/loot-core/src/server/aql/schema/run-query.ts	📈 +21 B (+3.26%)	645 B → 666 B
packages/loot-core/src/server/sync/repair.ts	📈 +21 B (+2.70%)	777 B → 798 B
packages/loot-core/src/server/update.ts	📈 +21 B (+2.37%)	886 B → 907 B
packages/loot-core/src/platform/server/fs/shared.ts	📈 +21 B (+2.22%)	948 B → 969 B
packages/loot-core/src/server/db/util.ts	📈 +21 B (+2.19%)	957 B → 978 B
packages/loot-core/src/server/budget/goals/goalsSimple.ts	📈 +21 B (+2.16%)	972 B → 993 B
packages/loot-core/src/server/accounts/payees.ts	📈 +21 B (+2.15%)	976 B → 997 B
packages/loot-core/src/server/util/budget-name.ts	📈 +21 B (+1.93%)	1.06 kB → 1.08 kB
packages/loot-core/src/server/sync/migrate.ts	📈 +21 B (+1.85%)	1.11 kB → 1.13 kB
packages/loot-core/src/server/budget/goals/goalsWeek.ts	📈 +21 B (+1.73%)	1.19 kB → 1.21 kB
packages/loot-core/src/server/importers/index.ts	📈 +21 B (+1.63%)	1.26 kB → 1.28 kB
packages/loot-core/src/server/errors.ts	📈 +21 B (+1.61%)	1.27 kB → 1.29 kB
packages/loot-core/src/shared/async.ts	📈 +21 B (+1.57%)	1.3 kB → 1.32 kB
packages/loot-core/src/server/budget/goals/goalsBy.ts	📈 +21 B (+1.45%)	1.42 kB → 1.44 kB
packages/loot-core/src/server/importers/actual.ts	📈 +21 B (+1.44%)	1.42 kB → 1.44 kB
packages/loot-core/src/server/budget/goals/goalsRemainder.ts	📈 +21 B (+1.40%)	1.47 kB → 1.49 kB
packages/loot-core/src/server/budget/goals/goalsPercentage.ts	📈 +21 B (+1.24%)	1.65 kB → 1.67 kB
packages/loot-core/src/server/budget/goals/goalsSpend.ts	📈 +21 B (+1.21%)	1.69 kB → 1.71 kB
packages/loot-core/src/server/app.ts	📈 +21 B (+1.15%)	1.79 kB → 1.81 kB
packages/loot-core/src/server/encryption.ts	📈 +21 B (+1.13%)	1.81 kB → 1.83 kB
packages/loot-core/src/server/db/sort.ts	📈 +21 B (+1.12%)	1.83 kB → 1.85 kB
packages/loot-core/src/server/db/mappings.ts	📈 +21 B (+1.08%)	1.9 kB → 1.92 kB
packages/loot-core/src/server/aql/views.ts	📈 +21 B (+1.08%)	1.9 kB → 1.92 kB
packages/loot-core/src/server/tools/app.ts	📈 +21 B (+0.97%)	2.11 kB → 2.13 kB
packages/loot-core/src/server/post.ts	📈 +21 B (+0.92%)	2.24 kB → 2.26 kB
packages/loot-core/src/server/prefs.ts	📈 +21 B (+0.87%)	2.35 kB → 2.37 kB
packages/loot-core/src/server/aql/exec.ts	📈 +21 B (+0.84%)	2.45 kB → 2.47 kB
packages/loot-core/src/server/api-models.ts	📈 +21 B (+0.82%)	2.49 kB → 2.51 kB
packages/loot-core/src/server/accounts/qif2json.ts	📈 +21 B (+0.79%)	2.61 kB → 2.63 kB
packages/loot-core/src/server/encryption-internals.web.ts	📈 +21 B (+0.71%)	2.9 kB → 2.92 kB
packages/loot-core/src/server/spreadsheet/graph-data-structure.ts	📈 +21 B (+0.71%)	2.91 kB → 2.93 kB
packages/loot-core/src/server/accounts/export-to-csv.ts	📈 +21 B (+0.70%)	2.92 kB → 2.94 kB
packages/loot-core/src/server/sync/reset.ts	📈 +21 B (+0.68%)	2.99 kB → 3.01 kB
packages/loot-core/src/platform/server/asyncStorage/index.web.ts	📈 +21 B (+0.65%)	3.16 kB → 3.18 kB
packages/loot-core/src/platform/server/fs/path-join.web.ts	📈 +21 B (+0.64%)	3.19 kB → 3.21 kB
packages/loot-core/src/server/rules/app.ts	📈 +21 B (+0.62%)	3.32 kB → 3.34 kB
packages/loot-core/src/server/accounts/parse-file.ts	📈 +21 B (+0.60%)	3.43 kB → 3.45 kB
packages/loot-core/src/shared/errors.ts	📈 +21 B (+0.60%)	3.43 kB → 3.45 kB
packages/loot-core/src/platform/server/connection/index.web.ts	📈 +21 B (+0.59%)	3.49 kB → 3.51 kB
packages/loot-core/src/shared/query.ts	📈 +21 B (+0.59%)	3.49 kB → 3.51 kB
packages/loot-core/src/server/budget/report.ts	📈 +21 B (+0.55%)	3.71 kB → 3.73 kB
packages/loot-core/src/server/mutators.ts	📈 +21 B (+0.55%)	3.71 kB → 3.74 kB
packages/loot-core/src/server/sync/encoder.ts	📈 +21 B (+0.55%)	3.74 kB → 3.76 kB
packages/loot-core/src/server/accounts/link.ts	📈 +21 B (+0.51%)	4 kB → 4.02 kB
packages/loot-core/src/server/migrate/migrations.ts	📈 +21 B (+0.51%)	4.03 kB → 4.05 kB
packages/loot-core/src/server/accounts/ofx2json.ts	📈 +21 B (+0.50%)	4.1 kB → 4.12 kB
packages/loot-core/src/server/models.ts	📈 +21 B (+0.46%)	4.42 kB → 4.44 kB
packages/loot-core/src/server/filters/app.ts	📈 +21 B (+0.43%)	4.73 kB → 4.75 kB
packages/loot-core/src/platform/server/sqlite/index.web.ts	📈 +21 B (+0.40%)	5.08 kB → 5.1 kB
packages/loot-core/src/platform/server/indexeddb/index.web.ts	📈 +21 B (+0.40%)	5.15 kB → 5.17 kB
packages/loot-core/src/server/accounts/title/index.ts	📈 +21 B (+0.39%)	5.24 kB → 5.26 kB
packages/loot-core/src/server/accounts/transactions.ts	📈 +21 B (+0.38%)	5.4 kB → 5.42 kB
packages/loot-core/src/server/budget/cleanup-template.ts	📈 +21 B (+0.37%)	5.55 kB → 5.57 kB
packages/loot-core/src/server/aql/schema-helpers.ts	📈 +21 B (+0.35%)	5.82 kB → 5.84 kB
packages/loot-core/src/server/accounts/transfer.ts	📈 +21 B (+0.35%)	5.9 kB → 5.92 kB
packages/loot-core/src/server/budget/rollover.ts	📈 +21 B (+0.34%)	6.03 kB → 6.05 kB
packages/loot-core/src/server/aql/schema/executors.ts	📈 +21 B (+0.31%)	6.53 kB → 6.55 kB
packages/loot-core/src/server/sheet.ts	📈 +21 B (+0.31%)	6.55 kB → 6.57 kB
packages/loot-core/src/server/backups.ts	📈 +21 B (+0.31%)	6.61 kB → 6.63 kB
packages/loot-core/src/server/budget/goals/goalsSchedule.ts	📈 +21 B (+0.30%)	6.77 kB → 6.79 kB
packages/loot-core/src/server/undo.ts	📈 +21 B (+0.30%)	6.85 kB → 6.87 kB
packages/loot-core/src/shared/rules.ts	📈 +21 B (+0.29%)	6.99 kB → 7.01 kB
packages/loot-core/src/shared/transactions.ts	📈 +21 B (+0.25%)	8.08 kB → 8.1 kB
packages/loot-core/src/shared/schedules.ts	📈 +21 B (+0.23%)	8.84 kB → 8.86 kB
packages/loot-core/src/shared/months.ts	📈 +21 B (+0.23%)	9 kB → 9.02 kB
packages/loot-core/src/shared/util.ts	📈 +21 B (+0.23%)	9.1 kB → 9.12 kB
packages/loot-core/src/server/budget/actions.ts	📈 +21 B (+0.22%)	9.51 kB → 9.54 kB
packages/loot-core/src/platform/server/fs/index.web.ts	📈 +21 B (+0.21%)	9.66 kB → 9.68 kB
packages/loot-core/src/server/importers/ynab5.ts	📈 +21 B (+0.20%)	10.28 kB → 10.3 kB
packages/loot-core/src/server/schedules/find-schedules.ts	📈 +21 B (+0.18%)	11.5 kB → 11.52 kB
packages/loot-core/src/server/spreadsheet/spreadsheet.ts	📈 +21 B (+0.17%)	12.07 kB → 12.09 kB
packages/loot-core/src/server/cloud-storage.ts	📈 +21 B (+0.17%)	12.16 kB → 12.18 kB
packages/loot-core/src/server/importers/ynab4.ts	📈 +21 B (+0.17%)	12.29 kB → 12.31 kB
packages/loot-core/src/server/aql/schema/index.ts	📈 +21 B (+0.16%)	12.66 kB → 12.68 kB
packages/loot-core/src/server/budget/base.ts	📈 +21 B (+0.14%)	14.82 kB → 14.84 kB
packages/loot-core/src/server/schedules/app.ts	📈 +21 B (+0.12%)	16.94 kB → 16.96 kB
packages/loot-core/src/server/api.ts	📈 +21 B (+0.12%)	17.1 kB → 17.12 kB
packages/loot-core/src/server/db/index.ts	📈 +21 B (+0.12%)	17.47 kB → 17.49 kB
packages/loot-core/src/server/budget/goaltemplates.ts	📈 +21 B (+0.10%)	20.91 kB → 20.93 kB
packages/loot-core/src/server/accounts/rules.ts	📈 +21 B (+0.09%)	23.09 kB → 23.11 kB
packages/loot-core/src/server/sync/index.ts	📈 +21 B (+0.09%)	23.21 kB → 23.23 kB
packages/loot-core/src/server/accounts/transaction-rules.ts	📈 +21 B (+0.08%)	27.13 kB → 27.15 kB
packages/loot-core/src/mocks/budget.ts	📈 +21 B (+0.07%)	28.5 kB → 28.52 kB
packages/loot-core/src/server/accounts/sync.ts	📈 +21 B (+0.07%)	30.68 kB → 30.7 kB
packages/loot-core/src/server/aql/compiler.ts	📈 +21 B (+0.06%)	34.74 kB → 34.76 kB
packages/loot-core/src/server/main.ts	📈 +21 B (+0.03%)	63.67 kB → 63.69 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.23 MB	0%