Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt] TypeScript - enable strictNullChecks #1426

Closed
MatissJanis opened this issue Jul 30, 2023 · 2 comments
Closed

[Tech Debt] TypeScript - enable strictNullChecks #1426

MatissJanis opened this issue Jul 30, 2023 · 2 comments
Labels
good first issue Good for newcomers maintenance Related to making the project easier to maintain tech debt Technical debt we should pay down

Comments

@MatissJanis
Copy link
Member

We should enable strictNullChecks. It is disabled by default.

Doing this won't be simple and will require fixing a lot of existing types.
@MatissJanis MatissJanis added good first issue Good for newcomers help wanted Extra attention is needed tech debt Technical debt we should pay down maintenance Related to making the project easier to maintain labels Jul 30, 2023
@j-f1
Copy link
Contributor

j-f1 commented Jul 30, 2023

Some work on this at https://github.com/actualbudget/actual/tree/jed/strict-null, but there are several hundred errors left to track down.

@MatissJanis
Copy link
Member Author

I recently enabled strict mode everywhere: #2230

So I'll close this off now. We can continue the migration (i.e. removal of strict comments) without needing an issue.

@github-actions github-actions bot removed the help wanted Extra attention is needed label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintenance Related to making the project easier to maintain tech debt Technical debt we should pay down
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatissJanis @j-f1