♻️ (typescript) enable strict mode everywhere (#2230)

package.json

@@ -38,7 +38,7 @@
     "rebuild-node": "yarn workspace loot-core rebuild",
     "lint": "eslint . --max-warnings 0",
     "lint:verbose": "DEBUG=eslint:cli-engine eslint . --max-warnings 0",
-    "typecheck": "yarn tsc",
+    "typecheck": "yarn tsc && tsc-strict",
     "jq": "./node_modules/node-jq/bin/jq"
   },
   "devDependencies": {
@@ -55,7 +55,8 @@
     "prettier": "2.8.2",
     "react-refresh": "^0.14.0",
     "source-map-support": "^0.5.21",
-    "typescript": "^5.0.2"
+    "typescript": "^5.0.2",
+    "typescript-strict-plugin": "^2.2.2-beta.2"
   },
   "engines": {
     "node": ">=18.0.0"

packages/api/methods.test.ts

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import * as fs from 'fs/promises';
 import * as path from 'path';
 

packages/desktop-client/src/ResponsiveProvider.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import { type ReactNode, createContext, useContext } from 'react';
 
 import { useViewportSize } from '@react-aria/utils';

packages/desktop-client/src/components/AnimatedRefresh.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React from 'react';
 
 import { keyframes } from 'glamor';

packages/desktop-client/src/components/App.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useEffect, useState } from 'react';
 import {
   ErrorBoundary,

packages/desktop-client/src/components/FatalError.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 
 import { Block } from './common/Block';

packages/desktop-client/src/components/FinancesApp.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ReactElement, useEffect, useMemo } from 'react';
 import { DndProvider } from 'react-dnd';
 import { HTML5Backend as Backend } from 'react-dnd-html5-backend';

packages/desktop-client/src/components/FixedSizeList.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import {
   createRef,
   PureComponent,

packages/desktop-client/src/components/GlobalKeys.ts

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import { useEffect } from 'react';
 
 import * as Platform from 'loot-core/src/client/platform';

packages/desktop-client/src/components/KeyHandlers.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { createContext, useEffect, useContext } from 'react';
 
 import hotkeys, { type KeyHandler as HotKeyHandler } from 'hotkeys-js';

packages/desktop-client/src/components/LoggedInUser.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState, useEffect } from 'react';
 import { useSelector } from 'react-redux';
 

packages/desktop-client/src/components/ManageRules.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   useState,
   useEffect,

packages/desktop-client/src/components/Modals.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useEffect } from 'react';
 import { useSelector } from 'react-redux';
 import { useLocation } from 'react-router-dom';

packages/desktop-client/src/components/Notes.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useEffect, useRef } from 'react';
 import ReactMarkdown from 'react-markdown';
 

packages/desktop-client/src/components/NotesButton.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 
 import { useLiveQuery } from 'loot-core/src/client/query-hooks';

packages/desktop-client/src/components/Notifications.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   useState,
   useEffect,

packages/desktop-client/src/components/PrivacyFilter.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   useState,
   useCallback,

packages/desktop-client/src/components/ScrollProvider.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   type ReactNode,
   createContext,

packages/desktop-client/src/components/ServerContext.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   createContext,
   useState,

packages/desktop-client/src/components/Titlebar.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   createContext,
   useState,

packages/desktop-client/src/components/UpdateNotification.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React from 'react';
 import { useSelector } from 'react-redux';
 

packages/desktop-client/src/components/alerts.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ComponentType, type ReactNode } from 'react';
 
 import { SvgExclamationOutline, SvgInformationOutline } from '../icons/v1';

packages/desktop-client/src/components/autocomplete/AccountAutocomplete.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { Fragment, type ComponentProps, type ReactNode } from 'react';
 
 import { css } from 'glamor';

packages/desktop-client/src/components/autocomplete/Autocomplete.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   useState,
   useRef,

packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   type ComponentProps,
   Fragment,

packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   Fragment,
   useState,

packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ComponentProps } from 'react';
 
 import { useFeatureFlag } from '../../hooks/useFeatureFlag';

packages/desktop-client/src/components/budget/BudgetMonthCountContext.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   createContext,
   type Dispatch,

packages/desktop-client/src/components/budget/BudgetPageHeader.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ComponentProps, memo } from 'react';
 
 import * as monthUtils from 'loot-core/src/shared/months';

packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { forwardRef, useEffect, type ComponentProps } from 'react';
 import { useSelector } from 'react-redux';
 import AutoSizer from 'react-virtualized-auto-sizer';

packages/desktop-client/src/components/budget/ExpenseCategory.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ComponentProps } from 'react';
 
 import { type CategoryEntity } from 'loot-core/src/types/models';

packages/desktop-client/src/components/budget/ExpenseGroup.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ComponentProps } from 'react';
 
 import { theme } from '../../style';

packages/desktop-client/src/components/budget/IncomeCategory.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ComponentProps } from 'react';
 
 import { type CategoryEntity } from 'loot-core/src/types/models';

packages/desktop-client/src/components/budget/IncomeGroup.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React from 'react';
 
 import { theme } from '../../style';

packages/desktop-client/src/components/budget/MobileBudget.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useEffect, useState } from 'react';
 import { useSelector } from 'react-redux';
 

packages/desktop-client/src/components/budget/MonthPicker.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import { type CSSProperties, useState } from 'react';
 
 import * as monthUtils from 'loot-core/src/shared/months';

packages/desktop-client/src/components/budget/MonthsContext.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { createContext, type ReactNode } from 'react';
 
 import * as monthUtils from 'loot-core/src/shared/months';

packages/desktop-client/src/components/budget/RenderMonths.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   useContext,
   type CSSProperties,

packages/desktop-client/src/components/budget/SidebarCategory.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type CSSProperties, type Ref, useState } from 'react';
 
 import { type CategoryEntity } from 'loot-core/src/types/models';

packages/desktop-client/src/components/budget/SidebarGroup.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type CSSProperties, useState } from 'react';
 import { type ConnectDragSource } from 'react-dnd';
 

packages/desktop-client/src/components/budget/index.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   memo,
   useContext,

packages/desktop-client/src/components/budget/report/ReportComponents.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { memo, useState } from 'react';
 
 import { reportBudget } from 'loot-core/src/client/queries';

packages/desktop-client/src/components/budget/report/ReportContext.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ReactNode, createContext, useContext } from 'react';
 
 import * as monthUtils from 'loot-core/src/shared/months';

packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 
 import { css } from 'glamor';

packages/desktop-client/src/components/budget/report/budgetsummary/BudgetTotal.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   type CSSProperties,
   type ComponentProps,

packages/desktop-client/src/components/budget/report/budgetsummary/fraction.ts

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 export function fraction(num, denom) {
   if (denom === 0) {
     if (num > 0) {

packages/desktop-client/src/components/budget/rollover/BalanceTooltip.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 
 import { rolloverBudget } from 'loot-core/src/client/queries';

packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ComponentProps, useState } from 'react';
 
 import { useCategories } from '../../../hooks/useCategories';

packages/desktop-client/src/components/budget/rollover/HoldTooltip.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   useState,
   useContext,

packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { memo, useState } from 'react';
 
 import { rolloverBudget } from 'loot-core/src/client/queries';

packages/desktop-client/src/components/budget/rollover/RolloverContext.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ReactNode, createContext, useContext } from 'react';
 
 import * as monthUtils from 'loot-core/src/shared/months';

packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   useState,
   useContext,

packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 
 import { css } from 'glamor';

packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState, type ComponentPropsWithoutRef } from 'react';
 
 import { css } from 'glamor';

packages/desktop-client/src/components/budget/util.ts

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import { type useSpreadsheet } from 'loot-core/src/client/SpreadsheetProvider';
 import { send } from 'loot-core/src/platform/client/fetch';
 import * as monthUtils from 'loot-core/src/shared/months';

packages/desktop-client/src/components/common/AlignedText.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import { type ComponentProps } from 'react';
 
 import { type CSSProperties } from '../../style';

packages/desktop-client/src/components/common/Button.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { forwardRef, type ElementType, type HTMLProps } from 'react';
 
 import { css } from 'glamor';

packages/desktop-client/src/components/common/InitialFocus.ts

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import {
   type ReactElement,
   type Ref,

packages/desktop-client/src/components/common/Input.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   useRef,
   type KeyboardEvent,

packages/desktop-client/src/components/common/InputWithContent.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import { useState, type ComponentProps, type ReactNode } from 'react';
 
 import { type CSSProperties, theme } from '../../style';

packages/desktop-client/src/components/common/Link.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ReactNode, type ComponentProps } from 'react';
 import { NavLink, useMatch } from 'react-router-dom';
 

packages/desktop-client/src/components/common/Menu.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import {
   type ReactNode,
   createElement,

packages/desktop-client/src/components/common/MenuButton.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React from 'react';
 
 import { SvgDotsHorizontalTriple } from '../../icons/v1';

packages/desktop-client/src/components/common/MenuTooltip.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React from 'react';
 
 import { Tooltip } from '../tooltips';

packages/desktop-client/src/components/common/Modal.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   useEffect,
   useRef,

packages/desktop-client/src/components/common/Search.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import { type ChangeEvent, type Ref } from 'react';
 
 import { SvgRemove, SvgSearchAlternate } from '../../icons/v2';

packages/desktop-client/src/components/common/Stack.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, {
   Children,
   type ComponentProps,

packages/desktop-client/src/components/filters/CompactFiltersButton.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React from 'react';
 
 import { SvgFilter } from '../../icons/v1';

packages/desktop-client/src/components/filters/FiltersButton.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React from 'react';
 
 import { SvgSettingsSliderAlternate } from '../../icons/v2';

packages/desktop-client/src/components/manager/ConfigServer.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState, useEffect } from 'react';
 
 import {

packages/desktop-client/src/components/manager/ImportActual.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 import { useDispatch } from 'react-redux';
 

packages/desktop-client/src/components/manager/ImportYNAB4.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 import { useDispatch } from 'react-redux';
 

packages/desktop-client/src/components/manager/ImportYNAB5.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 import { useDispatch } from 'react-redux';
 

packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 import { useDispatch } from 'react-redux';
 

packages/desktop-client/src/components/manager/subscribe/ChangePassword.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { useState } from 'react';
 
 import { send } from 'loot-core/src/platform/client/fetch';

packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React, { type ChangeEvent, useState } from 'react';
 
 import { ButtonWithLoading } from '../../common/Button';

packages/desktop-client/src/components/manager/subscribe/Error.tsx

@@ -1,3 +1,4 @@
+// @ts-strict-ignore
 import React from 'react';
 import { useLocation } from 'react-router-dom';