-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-3937] Create a tree-shakable module for realtime publishing #1504
Conversation
72b0574
to
b86a1ce
Compare
cce7de2
to
4ae8580
Compare
b86a1ce
to
57b879d
Compare
57b879d
to
d3fd4cb
Compare
4ae8580
to
b59bd66
Compare
d3fd4cb
to
ebf5883
Compare
b59bd66
to
3b881f8
Compare
ebf5883
to
e54b732
Compare
3b881f8
to
ed5ff7d
Compare
e54b732
to
f5a273e
Compare
Yeah, I think you're right that there's more that can be done. I think the mistake that I made is that I looked at the code and thought "oh, well, even if you're not publishing, you still have to send messages like |
ed5ff7d
to
c09cee7
Compare
f5a273e
to
0081d4f
Compare
c09cee7
to
875282c
Compare
0081d4f
to
79661e0
Compare
Owen mentioned that we have many browser use cases which only require subscriptions, and no publishing. He suggested that we create a separate tree-shakable module for this functionality. This commit introduces the API, but the bundle size savings are minimal since it only pulls out the very low-hanging fruit. I think that we could return to this at some point to see what further size savings we could achieve, but I didn’t want to spend too much time on this now. Resolves #1491.
79661e0
to
71eedc2
Compare
@owenpearson I've pushed another commit which moves the There is still a bit of What do you think? |
@lawrence-forooghian yeah i'm not really sure if it's worth it tbh - would probably be more convenient for the base client to include publishing than to potential save ~2kb for use cases which don't need realtime publishing :/ |
@owenpearson should I go ahead and close the issue then? |
@lawrence-forooghian yes please 👍 |
@owenpearson mentioned that we have many browser use cases which only require subscriptions, and no publishing. He suggested that we create a separate tree-shakable module for this functionality.
This commit introduces the API, but the bundle size savings are minimal since it only pulls out the very low-hanging fruit. I think that we could return to this at some point to see what further size savings we could achieve, but I didn’t want to spend too much time on this now.
Resolves #1491.