Investigate creating tree-shakable module for message publishing functionality #1491
Assignees
Comments
lawrence-forooghian
changed the title
|
➤ Automation for Jira commented: The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3937 |
lawrence-forooghian
added a commit
that referenced
this issue
Nov 16, 2023
Owen mentioned that we have many browser use cases which only require subscriptions, and no publishing. He suggested that we create a separate tree-shakable module for this functionality. This commit introduces the API, but the bundle size savings are minimal since it only pulls out the very low-hanging fruit. I think that we could return to this at some point to see what further size savings we could achieve, but I didn’t want to spend too much time on this now. Resolves #1491.
lawrence-forooghian
added a commit
that referenced
this issue
Nov 16, 2023
Owen mentioned that we have many browser use cases which only require subscriptions, and no publishing. He suggested that we create a separate tree-shakable module for this functionality. This commit introduces the API, but the bundle size savings are minimal since it only pulls out the very low-hanging fruit. I think that we could return to this at some point to see what further size savings we could achieve, but I didn’t want to spend too much time on this now. Resolves #1491.
lawrence-forooghian
added a commit
that referenced
this issue
Nov 16, 2023
Owen mentioned that we have many browser use cases which only require subscriptions, and no publishing. He suggested that we create a separate tree-shakable module for this functionality. This commit introduces the API, but the bundle size savings are minimal since it only pulls out the very low-hanging fruit. I think that we could return to this at some point to see what further size savings we could achieve, but I didn’t want to spend too much time on this now. Resolves #1491.
lawrence-forooghian
added a commit
that referenced
this issue
Nov 16, 2023
Owen mentioned that we have many browser use cases which only require subscriptions, and no publishing. He suggested that we create a separate tree-shakable module for this functionality. This commit introduces the API, but the bundle size savings are minimal since it only pulls out the very low-hanging fruit. I think that we could return to this at some point to see what further size savings we could achieve, but I didn’t want to spend too much time on this now. Resolves #1491.
lawrence-forooghian
added a commit
that referenced
this issue
Nov 16, 2023
Owen mentioned that we have many browser use cases which only require subscriptions, and no publishing. He suggested that we create a separate tree-shakable module for this functionality. This commit introduces the API, but the bundle size savings are minimal since it only pulls out the very low-hanging fruit. I think that we could return to this at some point to see what further size savings we could achieve, but I didn’t want to spend too much time on this now. Resolves #1491.
|
Attempted to implement this in #1504 but we weren't satisfied with the bundle size savings. Will not implement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@owenpearson mentioned that we have many browser use cases which only require subscriptions, and no publishing. He suggested that we create a separate tree-shakable module for this functionality.
This task exists to look into how much effort this would be, since the publishing functionality is quite entangled. I guess that, even if we were not able to fully split it into a separate module now, it would be good to have the module there in the API and we can work on reducing the size of the library without the module later.
The text was updated successfully, but these errors were encountered: