Exclude PresenceMessage from BaseRealtime bundle
#1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1505/features
github-actions
bot
temporarily deployed
to
staging/pull/1505/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1505/typedoc
lawrence-forooghian
force-pushed
the
1491-tree-shakable-publishing
branch
from
d3fd4cb to
ebf5883
Compare
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
29f876f to
bd48dc8
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1505/features
github-actions
bot
temporarily deployed
to
staging/pull/1505/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1505/typedoc
lawrence-forooghian
force-pushed
the
1491-tree-shakable-publishing
branch
from
ebf5883 to
e54b732
Compare
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
bd48dc8 to
954d6e7
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1505/features
github-actions
bot
temporarily deployed
to
staging/pull/1505/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1505/typedoc
lawrence-forooghian
force-pushed
the
1491-tree-shakable-publishing
branch
from
e54b732 to
f5a273e
Compare
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
954d6e7 to
b04f03f
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1505/features
github-actions
bot
temporarily deployed
to
staging/pull/1505/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1505/typedoc
owenpearson
approved these changes
Nov 24, 2023
owenpearson
reviewed
Nov 24, 2023
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
b04f03f to
3b0a73e
Compare
lawrence-forooghian
changed the base branch from
1491-tree-shakable-publishing
to
remove-static-from-Message-classes
lawrence-forooghian
force-pushed
the
remove-static-from-Message-classes
branch
from
c09cee7 to
875282c
Compare
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
3b0a73e to
fd7712d
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1505/features
github-actions
bot
temporarily deployed
to
staging/pull/1505/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1505/typedoc
Now PresenceMessage only gets included if you provide the RealtimePresence module.
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
fd7712d to
10bac3c
Compare
Base automatically changed from
remove-static-from-Message-classes
to
integration/v2
November 27, 2023 19:15
lawrence-forooghian
deleted the
exclude-PresenceMessage-from-base-realtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on top of #1503; please review that one first.
Now
PresenceMessageonly gets included if you provide theRealtimePresencemodule.