Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor main mecanism (a.k.a v2) #38

Closed
wants to merge 23 commits into from
Closed

Conversation

Taluu
Copy link
Contributor

@Taluu Taluu commented Jan 8, 2016

Ref #35, #16 and #5

  • Create the snapshot interfaces
  • implement the recursive
  • Refactor how the object snapshots are built
  • Refactor how the array snapshots are built
  • Refactor how the collection snapshot is built
  • Reflect changes on the Set
  • Implement "comparator"
  • Tests

@Taluu Taluu added this to the 2.X milestone Jan 8, 2016
@Taluu Taluu force-pushed the snapshotter branch 6 times, most recently from cee4335 to d1494cd Compare January 14, 2016 10:31
@Taluu Taluu changed the title Snapshotter Refactor main mecanism (a.k.a v2) Feb 2, 2016
No more voodoo, and no more horrible `setData` calls, which didn't make
sense ; snapshots are now responsible of their own "mutations"
@Taluu Taluu force-pushed the snapshotter branch 2 times, most recently from cd9076f to c2293fd Compare January 2, 2017 16:48
@coveralls
Copy link

Coverage Status

Coverage decreased (-16.8%) to 76.106% when pulling 8133834 on Taluu:snapshotter into 870c63e on Wisembly:master.

@peter279k
Copy link

The Travis CI build is failed because of the wrong PHPUnit namespace.

Using the PHPUnit\Framework\TestCase instead.

BTW, the commits are very large and it should squash all commits to one commit if possible.

@Taluu
Copy link
Contributor Author

Taluu commented Apr 7, 2019

Hum, guess this is expected, as the last build dates from (almost) 2 years ago, as I didn't continue (even if it's on my todo list, but as I'm not currently using this lib...).

And I'm against squashing commits, and prefer to stay true to the atomic commits rule (makes it easier with bisects when looking out for bugs, have a proper history, ... and so on). :}

@peter279k
Copy link

Ok. It makes sense :).

@Taluu
Copy link
Contributor Author

Taluu commented Jan 3, 2021

As it's been a while, I don't think continuing on this path is relevant anymore.

If I ever need to maintain this lib, I think I will do so differently than proposed right here.

Let's cleanup (But keep a branch for ref)

@Taluu Taluu closed this Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants