-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor main mecanism (a.k.a v2) #38
Conversation
cee4335
to
d1494cd
Compare
No more voodoo, and no more horrible `setData` calls, which didn't make sense ; snapshots are now responsible of their own "mutations"
cd9076f
to
c2293fd
Compare
The Travis CI build is failed because of the wrong Using the BTW, the commits are very large and it should squash all commits to one commit if possible. |
Hum, guess this is expected, as the last build dates from (almost) 2 years ago, as I didn't continue (even if it's on my todo list, but as I'm not currently using this lib...). And I'm against squashing commits, and prefer to stay true to the atomic commits rule (makes it easier with bisects when looking out for bugs, have a proper history, ... and so on). :} |
Ok. It makes sense :). |
As it's been a while, I don't think continuing on this path is relevant anymore. If I ever need to maintain this lib, I think I will do so differently than proposed right here. Let's cleanup (But keep a branch for ref) |
Ref #35, #16 and #5