Clone the snapshot in the collection mutator

Wisembly · Mar 24, 2017 · e90a67a · e90a67a
1 parent 9d50450
commit e90a67a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/composer.json b/composer.json
@@ -50,4 +50,3 @@
         }
     }
 }
-
diff --git a/src/Snapshot/CollectionSnapshot.php b/src/Snapshot/CollectionSnapshot.php
@@ -86,11 +86,11 @@ public function mutate(RecursiveSnapshotter $recursiveSnapshotter): Snapshot
 
         $clone = clone $this;
 
-        foreach ($clone->data as &$snapshot) {
-            $snapshot = $snapshot->mutate($recursiveSnapshotter);
+        foreach ($clone->data as $key => $snapshot) {
+            $snapshot = clone $snapshot;
+            $clone->data[$key] = $snapshot->mutate($recursiveSnapshotter);
         }
 
         return $clone;
     }
 }
-
diff --git a/test/Snapshot/CollectionSnapshotTest.php b/test/Snapshot/CollectionSnapshotTest.php
@@ -48,10 +48,11 @@ public function testMutate()
 
         $recursive->addSnapshotter($snapshotter);
 
-        $snapshot = new CollectionSnapshot(['foo'], [$snapshot->reveal()], [], true);
-        $snapshot = $snapshot->mutate($recursive);
+        $collectionSnapshot = new CollectionSnapshot(['foo'], [$snapshot->reveal()], [], true);
+        $mutatedSnapshot = $collectionSnapshot->mutate($recursive);
 
-        $this->assertInstanceOf(CollectionSnapshot::class, $snapshot);
+        $this->assertInstanceOf(CollectionSnapshot::class, $mutatedSnapshot);
+        $this->assertNotSame($mutatedSnapshot, $collectionSnapshot);
     }
 
     public function testItIsComparableToOtherCollectionSnapshots()