Refactor main mecanism (a.k.a v2)

.travis.yml

@@ -1,7 +1,7 @@
 language: php
 
 php:
-    - 7.0
+    - 7.1
     - hhvm
 
 matrix:
@@ -13,6 +13,7 @@ sudo: false
 
 install:
     - travis_retry composer install --prefer-source --no-interaction
+    - travis_retry composer require symfony/property-access --no-interaction
 
 script:
     - phpunit --coverage-text --coverage-clover clover.xml

composer.json

@@ -14,7 +14,6 @@
     ],
 
     "support": {
-        "email": "[email protected]",
         "issues": "https://github.com/Wisembly/Totem/issues",
         "source": "https://github.com/Wisembly/Totem"
     },
@@ -32,15 +31,22 @@
     },
 
     "require": {
-        "php": "^7.0",
+        "php": "^7.1",
+        "php-ds/php-ds": "^1.0"
+    },
+
+    "require-dev": {
         "symfony/property-access": "^3.0"
     },
 
+    "suggest": {
+        "symfony/property-access": "Allows to use the collection snapshotter"
+    },
+
     "extra": {
         "branch-alias": {
             "dev-master": "2.0-dev",
             "dev-1.x": "1.5-dev"
         }
     }
 }
-

phpunit.xml

@@ -20,8 +20,12 @@
     </testsuites>
 
     <filter>
-        <whitelist>
+        <whitelist processUncoveredFilesFromWhitelist="true">
             <directory suffix=".php">./src</directory>
+
+            <exclude>
+                <directory suffix="Exception.php">./src</directory>
+            </exclude>
         </whitelist>
     </filter>
 </phpunit>

src/AbstractChange.php → src/Change.php

@@ -17,7 +17,7 @@
  * @author Baptiste Clavié <[email protected]>
  * @author Rémy Gazelot <[email protected]>
  */
-abstract class AbstractChange implements ChangeInterface
+class Change
 {
     /** old state */
     private $old;

src/Change/Addition.php

@@ -11,31 +11,24 @@
 
 namespace Totem\Change;
 
-use Totem\ChangeInterface;
+use BadMethodCallException;
+use Totem\Change;
 
 /**
  * Represents something that was added in the original data
  *
  * @author Baptiste Clavié <[email protected]>
  */
-final class Addition implements ChangeInterface
+final class Addition extends Change
 {
-    /** @var mixed */
-    private $new;
-
     public function __construct($new)
     {
-        $this->new = $new;
+        parent::__construct(null, $new);
     }
 
     public function getOld()
     {
-        return null;
-    }
-
-    public function getNew()
-    {
-        return $this->new;
+        throw new BadMethodCallException('An addition does not have an old state');
     }
 }
 

src/Change/Removal.php

@@ -11,31 +11,24 @@
 
 namespace Totem\Change;
 
-use Totem\ChangeInterface;
+use BadMethodCallException;
+use Totem\Change;
 
 /**
  * Represents something that was removed from the original data
  *
  * @author Baptiste Clavié <[email protected]>
  */
-final class Removal implements ChangeInterface
+final class Removal extends Change
 {
-    /** @var mixed */
-    private $old;
-
     public function __construct($old)
     {
-        $this->old = $old;
+        parent::__construct($old, null);
     }
 
     public function getNew()
     {
-        return null;
-    }
-
-    public function getOld()
-    {
-        return $this->old;
+        throw new BadMethodCallException('A removal does not have a new state');
     }
 }