Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(update) translations added for these five languages : Amheric ,French, Khmer, Swahili and Portuguese #1888

Merged
merged 9 commits into from
Jul 4, 2024
Merged

(update) translations added for these five languages : Amheric ,French, Khmer, Swahili and Portuguese #1888

merged 9 commits into from
Jul 4, 2024

Conversation

Art-Ndiema
Copy link
Contributor

@Art-Ndiema Art-Ndiema commented Jul 1, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

This PR ensures we have translations in Amheric, French, Khmer,Swahili and Portuguese.

  • Files are cleaned up and all en.json files now have these five language files next to them.
  • Also suggesting on working on the dropdown to add these languages on the list.
  • Below are screenshots showing the translations in the UI.

Screenshots

Screenshot 2024-07-04 at 2 34 11 PM Screenshot 2024-07-04 at 2 44 32 PM Screenshot 2024-07-01 at 10 47 22 AM Screenshot 2024-07-01 at 10 48 21 AM Screenshot 2024-07-01 at 10 52 38 AM

Related Issue

https://ohri.atlassian.net/browse/OHRI-2240

Other

  • I noticed that the translators did not translate everything @hadijahkyampeire what can we do about that?

CynthiaKamau
CynthiaKamau reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Art-Ndiema , please undo the changes on the package.json and yarn.lock file since we use next openmrs version

CynthiaKamau
CynthiaKamau previously approved these changes Jul 1, 2024
View reviewed changes
hadijahkyampeire
hadijahkyampeire requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Art-Ndiema but I think you missed translating some values

packages/esm-cervical-cancer-app/translations/km.json Outdated Show resolved Hide resolved
packages/esm-cervical-cancer-app/translations/fr.json Outdated Show resolved Hide resolved
packages/esm-cervical-cancer-app/translations/am.json Outdated Show resolved Hide resolved
packages/esm-ohri-core-app/translations/km.json Outdated
@@ -0,0 +1,3 @@
{
"programmes": "Programmes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"programmes": "Programmes"
"programmes": "Programmes"
"programmes": "កម្មវិធី"

packages/esm-ohri-core-app/translations/am.json Outdated
@@ -0,0 +1,3 @@
{
"programmes": "Programmes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"programmes": "Programmes"
"programmes": "Programmes"
"programmes": "ፕሮግራሞች"

packages/esm-tb-app/translations/fr.json Outdated
@@ -0,0 +1,8 @@
{
"activeDrCases": "Active DR Cases",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets translate these, for example the first value should be Cas de reprise après sinistre actifs

hadijahkyampeire
hadijahkyampeire reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor cleanups

packages/esm-cervical-cancer-app/translations/am.json Outdated
@@ -0,0 +1,5 @@
{
"cacxSummary": "CaCx Summary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need these other English translations, all you need is the same key.

packages/esm-cervical-cancer-app/translations/fr.json Outdated
@@ -0,0 +1,4 @@
{
"cacxSummary": "CaCx Summary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

packages/esm-cervical-cancer-app/translations/km.json Outdated
@@ -0,0 +1,4 @@
{
"cacxSummary": "CaCx Summary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@GKMuthee
Copy link

GKMuthee commented Jul 3, 2024

@hadijahkyampeire @Art-Ndiema has Amharic been implemented on this PR?
Regarding your question on other languages: Portuguese and Swahili.
cc: @eudson @ebambo

@hadijahkyampeire
Copy link
Contributor

Thanks @GKMuthee , Amharic is already added, @Art-Ndiema will add Swahili and Portuguese

@Art-Ndiema
Copy link
Contributor Author

@GKMuthee I've added Swahili and Portuguese languages and did the clean ups, @hadijahkyampeire and @CynthiaKamau kindly review thank you

hadijahkyampeire
hadijahkyampeire approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Art-Ndiema , let's merge this

@hadijahkyampeire hadijahkyampeire merged commit df1de0e into dev Jul 4, 2024
5 checks passed
@hadijahkyampeire hadijahkyampeire deleted the translations branch July 4, 2024 08:28
@Art-Ndiema Art-Ndiema changed the title Translations added successfully for these three languages : Amheric ,French, Khmer Translations added successfully for these five languages : Amheric ,French, Khmer, Swahili and Portuguese Jul 4, 2024
@Art-Ndiema Art-Ndiema changed the title Translations added successfully for these five languages : Amheric ,French, Khmer, Swahili and Portuguese (update) translations added for these five languages : Amheric ,French, Khmer, Swahili and Portuguese Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadijahkyampeire hadijahkyampeire hadijahkyampeire approved these changes

@CynthiaKamau CynthiaKamau CynthiaKamau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Art-Ndiema @GKMuthee @hadijahkyampeire @CynthiaKamau