Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anrp/workflow #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anrp-tri
Copy link
Collaborator

@anrp-tri anrp-tri commented Oct 16, 2023

This change is Reviewable

Copy link
Collaborator

@amcastro-tri amcastro-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might help the review to update PR title and description.
E.g. What is this for? is this part of a PR train?

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@anrp-tri
Copy link
Collaborator Author

This simply runs bazel build in the GH action container (also gets enough of the used drake commit to install prereqs)
No train for this...just the beginning.

@anrp-tri
Copy link
Collaborator Author

Copy link
Collaborator

@amcastro-tri amcastro-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what I am looking at, pardon my ignorance.
What does this exactly mean? that when we push a commit into a PR IDTO gets build in CI? and from that log it'd seem that tests are still not running? (but pressumably will in fugure PRs)

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants